-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines requires different version of simplejson than mapreduce #9
Comments
👍 |
I agree. I think that we should just remove simplejson from pipeline library (version 2.1.1), it is included in requirement.txt in the correct version (the same as in mapreduce library). At the moment pipeline is broken because of old simplejson, even the tests are broken:
After removing simplejson:
Tests in my application also passed with this. Here is the pull request: #11 |
Is there a reason why it isn't: try:
import json as simplejson
except:
import simplejson ? For those of us that use the python27 runtime, we can benefit from the speedups afforded by the stdlib json import that has compiled c speedups and remove a dependency. |
Someone1: Good Point. Can you send a merge request? |
Various environment/import updates. (simple json -> json) See: #9
The simplejson lib should be added as a separate dependency (like what was done with the MapReduce library). The versions of these libs should be the same.
The text was updated successfully, but these errors were encountered: