spanner: fix stream destroy bug (#2358)

googleapis · Jun 5, 2017 · 03c276d · 03c276d
1 parent 925e651
commit 03c276d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/packages/spanner/src/transaction.js b/packages/spanner/src/transaction.js
@@ -371,7 +371,7 @@ Transaction.prototype.requestStream = function(config) {
       return;
     }
 
-    requestStream.destroy();
+    requestStream.end();
     userStream.destroy();
 
     if (self.shouldRetry_(err)) {

diff --git a/packages/spanner/test/transaction.js b/packages/spanner/test/transaction.js
@@ -612,6 +612,14 @@ describe('Transaction', function() {
         var error = { code: 10 };
         var stream;
 
+        var end = fakeStream.end;
+        var ended = false;
+
+        fakeStream.end = function() {
+          ended = true;
+          return end.call(fakeStream);
+        };
+
         transaction.shouldRetry_ = function(err) {
           assert.strictEqual(err, error);
           return true;
@@ -620,7 +628,7 @@ describe('Transaction', function() {
         transaction.runFn_ = done; // should not be called
 
         transaction.retry_ = function() {
-          assert(fakeStream._destroyed);
+          assert(ended);
           assert(stream._destroyed);
           done();
         };
@@ -635,6 +643,14 @@ describe('Transaction', function() {
         var error = { code: 10 };
         var stream;
 
+        var end = fakeStream.end;
+        var ended = false;
+
+        fakeStream.end = function() {
+          ended = true;
+          return end.call(fakeStream);
+        };
+
         var deadlineError = {};
         var createDeadlineError = Transaction.createDeadlineError_;
 
@@ -652,7 +668,7 @@ describe('Transaction', function() {
 
         transaction.runFn_ = function(err) {
           assert.strictEqual(err, deadlineError);
-          assert(fakeStream._destroyed);
+          assert(ended);
           assert(stream._destroyed);
 
           Transaction.createDeadlineError_ = createDeadlineError;