books.pb.go needs to be regenerated

[MakMukhi]

Hey,

We recently updated the grpc code and the protoc generator thereby rendering grpc.SupportPackageIsVersion3 obsolete. This will cause compile-time problems. Regenerating books.pb.go should work.
Under books dir run: protoc -I . books.proto --go_out=plugins=grpc:.

Thanks

[jab]

Thanks for opening this @MakMukhi!

Once the maintainers fix it this time, is there some way they can make sure it doesn't happen in the future, assuming that's possible? (e.g. Could a future update to grpc ever cause a change like const _ = grpc.SupportPackageIsVersion5 which would result in this breaking again?)

[MakMukhi]

Unfortunately, yes that might happen. Usually a project would regenerate their proto files at compile time. Give, this is a code lab they have provided the generated code to make things easier. But, this brings the onus of updating the code with changes to grpc code base (or provide instructions on how to do that).

…

On Wed, Feb 1, 2017 at 5:04 PM, jab ***@***.***> wrote: Thanks for opening this @MakMukhi <https://github.com/MakMukhi>! Once the maintainers fix it this time, is there some way they can make sure it doesn't happen in the future, assuming that's possible? (e.g. Could a future update to grpc ever cause a change like const _ = grpc.SupportPackageIsVersion5 which would result in this breaking again?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATtnR9Ebr04M_bZ5RAwC8bH0LXNp_pzVks5rYSuEgaJpZM4L0hLb> .

[markmandel]

This seems to be fine now. Please re-open if it becomes an issue again.