This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Self-hosted material icons and web fonts #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmc
approved these changes
Apr 10, 2017
|
|
||
| /* Support for all WebKit browsers. */ | ||
| -webkit-font-smoothing: antialiased; | ||
| /* Support for Safari and Chrome. */ |
There was a problem hiding this comment.
Should there be a blank line here, as there is between the lines just below?
There was a problem hiding this comment.
Fixed by removing all empty lines.
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url('source-code-pro-v6-latin-regular.eot'); /* IE9 Compat Modes */ | ||
| src: local('Source Code Pro'), local('SourceCodePro-Regular'), |
There was a problem hiding this comment.
Is the name 'SourceCodePro-Regular' required by some other use? On line 43 you use 'OpenSans', sans '-Regular'. Perhaps this should just be 'SourceCodePro' to match 'OpenSans'. Or maybe 'OpenSans' should be 'OpenSans-Regular'.
There was a problem hiding this comment.
I'm not actually sure, these were auto-generated, and I'm not comfortable changing things here since they're not very easy to testing because of the browser matrix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-hosting the icons and fonts gives us the following: