Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Add build script #23

Open
davelab6 opened this issue Nov 13, 2017 · 15 comments
Open

Add build script #23

davelab6 opened this issue Nov 13, 2017 · 15 comments

Comments

@davelab6
Copy link
Member

@djrrb
Copy link
Contributor

djrrb commented Nov 14, 2017

I’ve added one similar to Amstelvar. #24

Note that this does not cover the manual addition of a STAT table. Hopefully this will be added to fonttools varLib soon, so maybe not worth building in yet?

@djrrb djrrb closed this as completed Nov 14, 2017
@davelab6
Copy link
Member Author

davelab6 commented Nov 14, 2017 via email

@djrrb
Copy link
Contributor

djrrb commented Nov 14, 2017

totally scriptable...do we need parity between amstelvar and decovar build processes? I would do this in python instead of a shell script...

@djrrb djrrb reopened this Nov 14, 2017
@davelab6
Copy link
Member Author

davelab6 commented Nov 14, 2017

I don't need parity, I want a random type designer to be able to take the source files and reproduce the published binary with no fuss :) But that is rather ideal, and all that the contract requires is that you provide what you actually used to make your binary yourself, and adequate documentation for someone to reproduce what you did.

Section 15.2.2 provides more context if you want to nerd out on this stuff :) https://copyleft.org/guide/comprehensive-gpl-guidech16.html

@sberlow
Copy link

sberlow commented Nov 14, 2017

So a python script is ok?

@davelab6
Copy link
Member Author

So a python script is ok?

Absolutely! waf and SCons are the popular Python build systems, or you call roll your own in "make file style" (as in sphinx-doc/sphinx#3196), or just have a simple imperative python script file...

@djrrb
Copy link
Contributor

djrrb commented Nov 15, 2017

i'll make something basic tomorrow and we can always add a build system around it...not very knowledgeable about these different approaches

@davelab6
Copy link
Member Author

davelab6 commented Nov 15, 2017 via email

@djrrb
Copy link
Contributor

djrrb commented Nov 15, 2017

Well, the good news is that the latest fontTools now writes its own STAT table, so we no longer need to include a more complex build script to address it. :-)

The bad news is that the build script is finding some incompatibilities and not generating the VF as expected. So just wanted to let you know I’m still on top of automating the build process, but it might take a bit longer than expected, and the changes will affect the sources and not only the script itself.

@davelab6
Copy link
Member Author

davelab6 commented Nov 15, 2017 via email

@dberlow
Copy link

dberlow commented Nov 15, 2017 via email

@djrrb
Copy link
Contributor

djrrb commented Nov 15, 2017

no design changes...just to make them compatible or whatever needs doing to get Decovar to build from source without manual intervention

@dberlow
Copy link

dberlow commented Nov 15, 2017 via email

@djrrb
Copy link
Contributor

djrrb commented Nov 15, 2017

Haha ok good.

A basic STAT table is now being built by fontTools varLib (see commit here), so should now be included in all versions built with the latest fontTools.

There may be more source changes in store once more STAT-related data is specified in the designspace file (see discussion here)

@djrrb
Copy link
Contributor

djrrb commented Nov 18, 2017

I think this is ready to roll, see #25. Please review, merge, and close if this looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants