Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USE_MY_METRICS similar to how ufo2ft does it #267

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Set USE_MY_METRICS similar to how ufo2ft does it #267

merged 1 commit into from
Apr 20, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Apr 18, 2023

Builds on #266. Many Oswald glyphs now set USE_MY_METRICS and produce identical results to fontmake. Improves results for #250 (comment), 3.

@anthrotype
Copy link
Member

quoting from my previous self in googlefonts/ufo2ft#47

for fonts which are unhinted, or which are only hinted on the Y direction, this flag is innocuous, and doesn't make any difference whether it's set or not.

now I wonder if fontmake-rs should even bother with setting this flag, given that its outputs are unlikely to be hinted; and if they do get hinted, it's likely the responsibility of the hinting editor to set it...
only argument for adding this is to match fontmake-py's output verbatim, but from a functionality POV the (unhinted) font is the same with or without this.

@anthrotype
Copy link
Member

FYI I just added --no-auto-use-my-metrics option to fontmake (not released yet, currently only in main) which should help with comparisons. I would suggest that we don't bother implementing this in fontmake-rs given it doesn't affect rendering for unhinted fonts and hinting editors can set this if they do hint metrics (which is even rarer nowadays).

Base automatically changed from cc to main April 20, 2023 16:51
@rsheeter
Copy link
Contributor Author

Per IM discussion I still want to keep the ability to match fontmake default behavior here.

@rsheeter rsheeter merged commit 9eefbff into main Apr 20, 2023
@rsheeter rsheeter deleted the cflag branch April 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants