-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defcon.errors.DefconError: The kerning data is not valid while processing NotoSansEthiopic-MM.glyphs #13
Comments
Same error happens when: Inputs also for these two additional builds are attached. |
I think the problem here is that the Glyphs source contains conflicting kerning rules, which are rejected on UFO load by defcon. We didn't have this problem with RoboFab (the conflicting kerning rules are removed when the feature is written), but interpolation via MutatorMath uses defcon so we have to deal with this earlier than on feature write. @adrientetar do you know of some tool that can remove conflicting kerning in defcon or elsewhere? |
I don't. Btw kerning is normally loaded lazily but needs to be processed on open when converting from a legacy ufo version. |
Hm. This is still a bit of a pain to deal with because robofab doesn't support ufo3. FYI @behdad it's starting to look like we need to scrap use of robofab universally in favor of defcon, if only for compatibility with MutatorMath (this would also apply to Roboto, if we want to use it there). |
Sounds like more work than we previously planned. However, I'm all for On Wed, Feb 17, 2016 at 3:06 PM, James Godfrey-Kittle <
Marek Z Jeziorek [ 老马 ] | marekj@google.com | 312 725-6958 |
Great idea (cc @graphicore), ufo3 has things like layers standardized so you don't need to use robofont extensions to the spec anywhere. defcon itself has many refinements in the ufo3 branch and, as you found out, validates data. |
👍 for dropping robofab in favour of defcon+ufo3! |
Correct. I'll take a look into this issue. I'm new to defcon, but see what I can figure out. |
But, kerning is still validated by defcon on UFO save so using defcon doesn't really help us here. It's looking to me like we have no choice but to remove the duplicate kerning earlier if we use MutatorMath. Of course we can still switch to defcon since it seems like the right thing to do. |
So, is the kerning data in one of the masters invalid? Then that's a source bug. @jamesgk can you make defcon report the invalid pairs? validateKerning definitely generates those, but they are lost in the exception. It also occurs to me that:
|
So, is it OK if fontmake chokes on invalid kerning? My concern is that Glyphs does not.
They are passed on by defcon via an attribute of the exception object; we can print that out in glyphs2ufo where mutatorMath is called. |
BTW, there are quite a lot (948) of these conflicting rules in Noto Sans Ethiopic. The first 10:
|
Thanks. I'll take a look. On Tue, Mar 1, 2016 at 8:27 AM, James Godfrey-Kittle <
behdad |
The original issue here should be fixed. New issues can be spun off e.g. for migration to defcon (one already exists in ufoLib for updating validateKerning). |
The pipeline built on both 10/Feb and 12/Feb fails to build NotoSansEthiopic fonts.
I have attached the input file used for the pipeline.
NotoSansEthiopic-MM.glyphs.zip
The text was updated successfully, but these errors were encountered: