v3.000: Support variable fonts #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on prebuilt docker+uwsgi+nginx image https://github.com/tiangolo/uwsgi-nginx-flask-docker instead
The previous implementation used the font's nametable. This approach was too unreliable.
Sometimes diffing the families isn't needed. A user may just want to compare two fonts in a waterfall (for hinting purposes) or play with the editor.
Hinters want to see all the glyphs contained in a font
User will have to provide an Access-Token in header to post media
|
@m4rc1e ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on this for the past two months. Micah, Eli and Mike have been using it frequently so I think we've found most of the major issues.
Apart from adding VF support, the following improvements have been made:
Atm, it can't use a font's width axis (same as GF). I hope to have this in place once we know what values to use, google/fonts#1706
I'm also not updating www.gf-regression.com until I have the following in place:
Even by making these updates, the hardware it currently runs on isn't sufficient anymore. I would prefer people to use fontdiffenator instead, especially since it will be able to generate diff images soon. My current setup is to use the new GFR instance with diffbrowsers and fontdiffenator.