Readme instructions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Thanks! |
|
I see Tal merged your feaTools changes. Should you switch back to his tree? |
|
I'm merging this, but please apply the comments above in a later patch. |
roozbehp
added a commit
that referenced
this pull request
Apr 22, 2015
Merge build updates to readme file from James.
roozbehp
added a commit
that referenced
this pull request
May 22, 2015
Merge build updates to readme file from James.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is what you were thinking -- these instructions are pretty thorough and long. Though I suppose the complexity of getting set up is what makes this necessary.
(Also serves as a test of code reviews via pull requests.)