Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version specification pattern in the Unity SDK installation document does not match the actual release tag #2622

Closed
kt81 opened this issue Jun 10, 2022 · 2 comments · Fixed by #3071
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone

Comments

@kt81
Copy link

kt81 commented Jun 10, 2022

What happened:

When installing the SDK using the Unity Package Manager, I get a "Not found" error when I enter the version specification string according to the documentation.

Added to manifest.json:

"com.googleforgames.agones": "https://github.com/googleforgames/agones.git?path=/sdks/unity#1.19.0",

Result on console:

[Package Manager Window] Unable to add package [https://github.com/googleforgames/agones.git?path=/sdks/unity#1.19.0]:
  Could not clone [https://github.com/googleforgames/agones.git]. Revision [1.19.0] could not be found.
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

What you expected to happen:

Installed specific version of Client Server SDK for Unity.

The example on the document should have the version along with the "v" (v1.19.0)

How to reproduce it (as minimally and precisely as possible):

Copy the line from the document to manifest.json or input https://github.com/googleforgames/agones.git?path=/sdks/unity#1.19.0 using Add package from git URL... in UPM.

Anything else we need to know?:

Environment:

  • Agones version: >= 1.19.0
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others: Unity 2020.3.8f1
@kt81 kt81 added the kind/bug These are bugs. label Jun 10, 2022
@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/documentation Documentation for Agones labels Jun 10, 2022
@markmandel
Copy link
Member

If someone goes in and fixes this, would probably be good to use the shortcode for the current release version, that way it will automatically increment with each release.

@oniku-2929
Copy link
Contributor

I'll fix it.

markmandel pushed a commit that referenced this issue Apr 5, 2023
Co-authored-by: oniku2929 <o29n1ku2ku@gmail.com>
chiayi pushed a commit to chiayi/agones that referenced this issue Apr 5, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this issue Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants