[Flake] Unit Test: TestControllerGameServerCount

[markmandel]

What happened:

Flake:

{"message":"Wait for cache sync","severity":"info","time":"2022-11-10T23:29:25.722243823Z"}
{"message":"unable to calculate 'Creating' state duration of '89hzzgz67v' GameServer","severity":"warning","source":"*metrics.Controller","time":"2022-11-10T23:29:25.828551589Z"}
{"message":"unable to calculate 'Ready' state duration of '89hzzgz67v' GameServer","severity":"warning","source":"*metrics.Controller","time":"2022-11-10T23:29:26.829692585Z"}
--- FAIL: TestControllerGameServerCount (3.11s)
    controller_test.go:76: 
        	Error Trace:	controller_test.go:76
        	            				controller_test.go:146
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 4
        	Test:       	TestControllerGameServerCount
        	Messages:   	number of timeseries does not match under metric: gameservers_count
    controller_test.go:83: 
        	Error Trace:	controller_test.go:83
        	            				controller_test.go:146
        	Error:      	Should be true
        	Test:       	TestControllerGameServerCount
        	Messages:   	no TimeSeries found with labels: [test-fleet default Creating]
    controller_test.go:84: 
        	Error Trace:	controller_test.go:84
        	            				controller_test.go:146
        	Error:      	Not equal: 
        	            	expected: []string(nil)
        	            	actual  : []string{"test-fleet", "default", "Creating"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,6 @@
        	            	-([]string) <nil>
        	            	+([]string) (len=3) {
        	            	+ (string) (len=10) "test-fleet",
        	            	+ (string) (len=7) "default",
        	            	+ (string) (len=8) "Creating"
        	            	+}
        	            	 
        	Test:       	TestControllerGameServerCount
        	Messages:   	label values don't match
    controller_test.go:86: 
        	Error Trace:	controller_test.go:86
        	            				controller_test.go:146
        	Error:      	Not equal: 
        	            	expected: <nil>(<nil>)
        	            	actual  : int64(0)
        	Test:       	TestControllerGameServerCount
        	Messages:   	metric: gameservers_count, tags: [{test-fleet true} {default true} {Creating true}], values don't match; got: 0, want: <nil>
{"message":"Wait for cache sync","severity":"info","time":"2022-11-10T23:29:28.833974642Z"}
{"message":"Wait for cache sync","severity":"info","time":"2022-11-10T23:29:30.939633368Z"}

What you expected to happen:

The test to pass always

How to reproduce it (as minimally and precisely as possible):

Run the test lots.

Anything else we need to know?:

It mostly passes!

Environment:

• Agones version: dev
• Kubernetes version (use kubectl version): N/A
• Cloud provider or hardware configuration: N/A
• Install method (yaml/helm): N/A
• Troubleshooting guide log(s): See above.
• Others: N/A