Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the github.com/pkg/errors dependency from the repo #2870

Closed
aimuz opened this issue Dec 15, 2022 · 3 comments
Closed

Remove the github.com/pkg/errors dependency from the repo #2870

aimuz opened this issue Dec 15, 2022 · 3 comments
Labels
kind/feature New features for Agones wontfix Sorry, but we're not going to do that.

Comments

@aimuz
Copy link
Collaborator

aimuz commented Dec 15, 2022

Is your feature request related to a problem? Please describe.

github.com/pkg/errors The archive is no longer being updated, and std errors provides the ability to do so, so I want to remove github.com/pkg/errors and switch back to using the standard library.

What do you think? I will do this if you agree

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@aimuz aimuz added the kind/feature New features for Agones label Dec 15, 2022
@markmandel
Copy link
Member

std errors doesn't provide all the functionality of github.com/pkg/errors - particularly capturing a stack trace with an error. So I'd be against this for now.

From github.com/pkg/errors:

With the upcoming Go2 error proposals this package is moving into maintenance mode.

So it is maintenance mode, but waiting to be replaced by the Go2 proposal. So I would argue we shouldn't switch out until that lands.

@aimuz
Copy link
Collaborator Author

aimuz commented Dec 15, 2022

Thank you

pkg/errors#245

errors has gone into read-only mode due to lack of new maintainers.

If we are currently relying on stack trace, then we can indeed wait a bit longer, as all the features have been largely implemented except for stack trace

@markmandel markmandel added the wontfix Sorry, but we're not going to do that. label Dec 16, 2022
@markmandel
Copy link
Member

Cleaning up as wontfix. We can revisit if the state of error management in Go changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones wontfix Sorry, but we're not going to do that.
Projects
None yet
Development

No branches or pull requests

2 participants