-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdkserver: add functionality to set multiple game server annotations at once #3835
Comments
Hi @antiphp I would like to help out with this issue, I am new to the project and just had a few questions before jumping in. Reading your solution it sounds like changing the agones/pkg/sdkserver/sdkserver.go Line 124 in 2f1c2a8
SetAnnotation (singular) to either append or overwrite.
Then adding a Is that the line of thinking you would like here? Or do you think changing that property of the |
Hi, the function signature for What's the thinking behind append vs overwrite? In my opinion, the latter key will always overwrite, so Btw this ticket is related: #3834 - Removal of annotations. Thanks for taking the initiative! |
The idea to use append vs overwrite was so that we could handle updating multiple different annotations in the same function i.e. we would get I was thinking originally that we just wanted to be able to add multiple annotations that are passed to the function at once to a GameServer object. However it seems like the ask is more of not only add the annotations but to update the values of them as well. Which if that is the case I would agree completely that overwrite is the way to go instead of append. |
👋 Are you still interested in opening a PR for that @frenchtoasters ? Otherwise I am thinking about doing it by myself in the near future. |
Is your feature request related to a problem? Please describe.
When someone watches for game server changes, it is preferred to see one change, rather than many where it is hard to determine when the sequence of changes is finished.
Describe the solution you'd like
I suggest to implement a function for the sdk server to set multiple annotations at once. Currently only
SetAnnotation
(singular) exists.Describe alternatives you've considered
Set an annotation that indicates that this is the last annotation.
Additional context
Related code: https://github.com/googleforgames/agones/blob/main/pkg/sdkserver/sdkserver.go#L580
The text was updated successfully, but these errors were encountered: