Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdkserver: add functionality to remove game server annotations #3834

Open
antiphp opened this issue May 22, 2024 · 2 comments
Open

sdkserver: add functionality to remove game server annotations #3834

antiphp opened this issue May 22, 2024 · 2 comments
Labels
kind/feature New features for Agones stale Pending closure unless there is a strong objection.

Comments

@antiphp
Copy link
Contributor

antiphp commented May 22, 2024

Is your feature request related to a problem? Please describe.
When the game server resets itself, e.g. from being allocated back to ready, it is required to reset exposed information like annotations too.

Describe the solution you'd like
I suggest to implement a function for the sdk server to remove an annotation. The recommended way to expose information from the game server is among others setting annotations (https://agones.dev/site/docs/faq/#how-can-i-expose-information-from-my-game-server-binary-to-an-external-service). This should include removing a previously set annotation.

Describe alternatives you've considered
Overriding with empty string.

Additional context
Related code: https://github.com/googleforgames/agones/blob/v1.43.0/pkg/sdkserver/sdkserver.go#L582

@antiphp
Copy link
Contributor Author

antiphp commented Sep 25, 2024

Accepting an empty string to delete the annotation would be BC, so this must be separate function.

Would open a PR if or when #3835 has been resolved.

Copy link

github-actions bot commented Nov 1, 2024

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones stale Pending closure unless there is a strong objection.
Projects
None yet
Development

No branches or pull requests

1 participant