Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a delay flag to the sdkserver #1070

Merged
merged 1 commit into from Sep 25, 2019
Merged

Add a delay flag to the sdkserver #1070

merged 1 commit into from Sep 25, 2019

Conversation

roberthbailey
Copy link
Member

To enable test scenarios where it doesn't start up immediately.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8d6cd4d5-cf1a-401b-ace0-2dfdb51cc359

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1070/head:pr_1070 && git checkout pr_1070
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-aab5c61

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bb18f7c8-756b-4f90-8b00-1b2c100bbc9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1070/head:pr_1070 && git checkout pr_1070
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-6d83b09

markmandel
markmandel approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Sep 25, 2019
@markmandel markmandel added this to the 1.1.0 milestone Sep 25, 2019
@markmandel markmandel merged commit 85bb01f into googleforgames:master Sep 25, 2019
@markmandel markmandel added the kind/feature New features for Agones label Oct 22, 2019
@roberthbailey roberthbailey deleted the sdkserver-delay-flag branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@joeholley joeholley Awaiting requested review from joeholley

Assignees

@markmandel markmandel

Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel