Update the instructions for installing a GKE cluster with terraform to disable automatic node upgrades

[roberthbailey]

This is the second part of #1137.

/assign @markmandel

[agones-bot]

Build Succeeded 👏

Build Id: 0657a26f-1150-4134-9912-c502ad56b059

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-394e299
• image: gcr.io/agones-images/agones-sdk:1.1.0-394e299
• image: gcr.io/agones-images/agones-ping:1.1.0-394e299
• Linux C++ SDK (build): agonessdk-1.1.0-394e299-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-394e299.zip

A preview of the website (the last 30 builds are retained):

• https://394e299-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1141/head:pr_1141 && git checkout pr_1141
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-394e299

[agones-bot]

Build Succeeded 👏

Build Id: 75d462b3-187f-4f47-a456-249a8cf6fbfa

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-6d9ed13
• image: gcr.io/agones-images/agones-sdk:1.1.0-6d9ed13
• image: gcr.io/agones-images/agones-ping:1.1.0-6d9ed13
• Linux C++ SDK (build): agonessdk-1.1.0-6d9ed13-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-6d9ed13.zip

A preview of the website (the last 30 builds are retained):

• https://6d9ed13-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1141/head:pr_1141 && git checkout pr_1141
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-6d9ed13

[markmandel]

This looks good to me - @aLekSer can you check the terraform bits real quick, just because you know TF way better than I do.

[agones-bot]

Build Succeeded 👏

Build Id: 17f1e672-2040-4c45-97cf-9957ccd020a5

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-2ae3610
• image: gcr.io/agones-images/agones-sdk:1.1.0-2ae3610
• image: gcr.io/agones-images/agones-ping:1.1.0-2ae3610
• Linux C++ SDK (build): agonessdk-1.1.0-2ae3610-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-2ae3610.zip

A preview of the website (the last 30 builds are retained):

• https://2ae3610-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1141/head:pr_1141 && git checkout pr_1141
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2ae3610

[agones-bot]

Build Succeeded 👏

Build Id: 5e07872d-9e1a-4de2-9927-2c25403e8595

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-b778fb6
• image: gcr.io/agones-images/agones-sdk:1.1.0-b778fb6
• image: gcr.io/agones-images/agones-ping:1.1.0-b778fb6
• Linux C++ SDK (build): agonessdk-1.1.0-b778fb6-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-b778fb6.zip

A preview of the website (the last 30 builds are retained):

• https://b778fb6-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1141/head:pr_1141 && git checkout pr_1141
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b778fb6

[agones-bot]

Build Succeeded 👏

Build Id: a7090b10-aafe-400c-ba94-e347eda0fa96

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.1.0-b79e3ee
• image: gcr.io/agones-images/agones-sdk:1.1.0-b79e3ee
• image: gcr.io/agones-images/agones-ping:1.1.0-b79e3ee
• Linux C++ SDK (build): agonessdk-1.1.0-b79e3ee-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.1.0-b79e3ee.zip

A preview of the website (the last 30 builds are retained):

• https://b79e3ee-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1141/head:pr_1141 && git checkout pr_1141
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b79e3ee

[aLekSer]

Now terraform config looks much better.
Approving these changes also.

[markmandel]

@roberthbailey I'm leaning towards merging this after 1.1.0 stable, just because it changes actual code -- but what do you think? I could also be persuaded to merge this now?

[roberthbailey]

what do you think?

I'd lean towards doing it now, before the release cut.

The terraform example always pulls the cluster.tf file from the master branch (source = "git::https://github.com/googleforgames/agones.git//build/?ref=master") so even if you merge later, running the example will pick up the changes to disable node auto updates.

Then what's missing is the documentation updates and the updates to the example. The documentation updates could be guarded behind the 1.2 release and the example changes would be visible in the master branch but not on the release branch.

[markmandel]

SGTM. You have a stronger opinion than mine 👍

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment