Pass FEATURE_GATES flag to e2e tests #1445

akremsa · 2020-04-02T13:51:18Z

This PR is a part of #1411 and allows to turn on\off feature gates behaviour in e2e tests.

Also updated some tests introduced in #1396

aLekSer

Now we can switch between Features to create 2 separate E2E tests CI pipelines.

test/e2e/main_test.go

agones-bot · 2020-04-02T13:59:27Z

Build Failed 😱

Build Id: a8f9205d-0f00-4f15-83b0-5badfca7a6fe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-02T14:11:00Z

Build Failed 😱

Build Id: acfb6bfa-0773-4a9a-b605-cd68b77c1387

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-02T14:31:32Z

Build Failed 😱

Build Id: 702814fd-dc04-4075-a53a-6b1fabafc073

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-02T14:37:09Z

Build Failed 😱

Build Id: 0ccfd2a5-24b4-415f-99e7-0fc79090a22c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-02T14:39:14Z

I think we need to update build/e2e-image/e2e.sh
Or add default parameter :

test-e2e: FEATURE_GATES ?= "PlayerCount=true&ContainerPort=true"
test-e2e:
	$(MAKE) test-e2e-integration
	$(MAKE) test-e2e-failure

akremsa · 2020-04-02T14:49:28Z

FEATURE_GATES

Moved FEATURE_GATES the the top of Makefile

agones-bot · 2020-04-02T15:01:42Z

Build Succeeded 👏

Build Id: fcc69dc0-b516-4e37-8932-e6d701994537

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-0b2e3c0
image: gcr.io/agones-images/agones-sdk:1.5.0-0b2e3c0
image: gcr.io/agones-images/agones-ping:1.5.0-0b2e3c0
Linux C++ SDK (build): agonessdk-1.5.0-0b2e3c0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-0b2e3c0.zip

A preview of the website (the last 30 builds are retained):

https://0b2e3c0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-0b2e3c0

aLekSer

Now install and test-e2e uses same FeatureGates by default.

test/e2e/main_test.go

agones-bot · 2020-04-02T16:25:36Z

Build Succeeded 👏

Build Id: d259f19d-1afa-4c52-ac06-d32695ac3fa6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-d9702d6
image: gcr.io/agones-images/agones-sdk:1.5.0-d9702d6
image: gcr.io/agones-images/agones-ping:1.5.0-d9702d6
Linux C++ SDK (build): agonessdk-1.5.0-d9702d6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-d9702d6.zip

A preview of the website (the last 30 builds are retained):

https://d9702d6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-d9702d6

agones-bot · 2020-04-02T16:36:43Z

Build Succeeded 👏

Build Id: f9588e58-98d1-4a79-9c39-7adb4f8c6f0f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-8c47647
image: gcr.io/agones-images/agones-sdk:1.5.0-8c47647
image: gcr.io/agones-images/agones-ping:1.5.0-8c47647
Linux C++ SDK (build): agonessdk-1.5.0-8c47647-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-8c47647.zip

A preview of the website (the last 30 builds are retained):

https://8c47647-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-8c47647

test/e2e/framework/framework.go

aLekSer · 2020-04-18T14:57:05Z

@akremsa Well, it seems that moving FEATURE_GATES up to a global level results in failing SDK conformance tests. What I would recommend is to change sdk.mk and set FEATURE_GATES there also,for some test it should be "". Or we should specify this variable for E2E tests and install separately.

Step #22 - "sdk-conformance": DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9002 -e AGONES_SDK_HTTP_PORT=9102 -e FEATURE_GATES="PlayerTracking=true&ContainerPortAllocation=true" " COMMAND=sdktest /usr/bin/make run-sdk-command & \
Step #22 - "sdk-conformance": docker run -p 9002:9002 -p 9102:9102 -e "FEATURE_GATES="PlayerTracking=true&ContainerPortAllocation=true"" -e "ADDRESS=" -e "TEST=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve" -e "SDK_NAME=node" -e "TIMEOUT=30" -e "DELAY=3" \

Previously with Successful SDK test runs this parameter was an empty string:

DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9002 -e AGONES_SDK_HTTP_PORT=9102 -e FEATURE_GATES= " COMMAND=sdktest /usr/bin/make run-sdk-command & \
Step #22 - "sdk-conformance": docker run -p 9002:9002 -p 9102:9102 -e "FEATURE_GATES=" -e "ADDRESS=" -e "TEST=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve" -e "SDK_NAME=node" -e "TIMEOUT=30" -e "DELAY=4" \
Step #22 - "sdk-conformance": --net=host gcr.io/agones-images/agones-sdk:1.6.0-75ba12c --grpc-port 9002 --http-port 9102
Step #22 - "sdk-conformance": DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9003 -e AGONES_SDK_HTTP_PORT=9103 -e FEATURE_GATES= " COMMAND=sdktest /usr/bin/make run-sdk-command

agones-bot · 2020-04-18T15:50:20Z

Build Failed 😱

Build Id: 43495c1f-8940-4b43-af91-47b876a67ec6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-20T11:21:58Z

Build Succeeded 👏

Build Id: 0ec5d536-1c65-490b-bdf3-7f0d73217148

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-db126ad
image: gcr.io/agones-images/agones-sdk:1.6.0-db126ad
image: gcr.io/agones-images/agones-ping:1.6.0-db126ad
Linux C++ SDK (build): agonessdk-1.6.0-db126ad-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-db126ad.zip

A preview of the website (the last 30 builds are retained):

https://db126ad-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-db126ad

akremsa · 2020-04-20T11:28:03Z

@akremsa Well, it seems that moving FEATURE_GATES up to a global level results in failing SDK conformance tests. What I would recommend is to change sdk.mk and set FEATURE_GATES there also,for some test it should be "". Or we should specify this variable for E2E tests and install separately.

Step #22 - "sdk-conformance": DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9002 -e AGONES_SDK_HTTP_PORT=9102 -e FEATURE_GATES="PlayerTracking=true&ContainerPortAllocation=true" " COMMAND=sdktest /usr/bin/make run-sdk-command & \
Step #22 - "sdk-conformance": docker run -p 9002:9002 -p 9102:9102 -e "FEATURE_GATES="PlayerTracking=true&ContainerPortAllocation=true"" -e "ADDRESS=" -e "TEST=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve" -e "SDK_NAME=node" -e "TIMEOUT=30" -e "DELAY=3" \

Previously with Successful SDK test runs this parameter was an empty string:

DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9002 -e AGONES_SDK_HTTP_PORT=9102 -e FEATURE_GATES= " COMMAND=sdktest /usr/bin/make run-sdk-command & \
Step #22 - "sdk-conformance": docker run -p 9002:9002 -p 9102:9102 -e "FEATURE_GATES=" -e "ADDRESS=" -e "TEST=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve" -e "SDK_NAME=node" -e "TIMEOUT=30" -e "DELAY=4" \
Step #22 - "sdk-conformance": --net=host gcr.io/agones-images/agones-sdk:1.6.0-75ba12c --grpc-port 9002 --http-port 9102
Step #22 - "sdk-conformance": DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=9003 -e AGONES_SDK_HTTP_PORT=9103 -e FEATURE_GATES= " COMMAND=sdktest /usr/bin/make run-sdk-command

Fixed

build/includes/sdk.mk

markmandel · 2020-04-20T22:23:33Z

pkg/util/runtime/features.go

@@ -25,7 +25,8 @@ import (
 )

 const (
-	featureGateFlag = "feature-gates"
+	// FeatureGateFlag is a name of a command line flag, which turns on specific tests for FeatureGates
+	FeatureGateFlag = "feature-gates"


build/Makefile

agones-bot · 2020-04-20T23:33:42Z

Build Succeeded 👏

Build Id: b745285d-8864-4e7f-bff1-5ffecd9d9f92

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-0bd2e7a
image: gcr.io/agones-images/agones-sdk:1.6.0-0bd2e7a
image: gcr.io/agones-images/agones-ping:1.6.0-0bd2e7a
Linux C++ SDK (build): agonessdk-1.6.0-0bd2e7a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-0bd2e7a.zip

A preview of the website (the last 30 builds are retained):

https://0bd2e7a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-0bd2e7a

build/Makefile

fix fix

aLekSer

Thanks for an update. Now running E2E tests make test-e2e FEATURE_FLAGS="" is possible on the cluster with stable features only and others disabled.

agones-bot · 2020-04-21T07:12:05Z

Build Succeeded 👏

Build Id: 45e8c9e4-bbc1-4fd4-88b0-8f96df5aa6b2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-5a0c9d3
image: gcr.io/agones-images/agones-sdk:1.6.0-5a0c9d3
image: gcr.io/agones-images/agones-ping:1.6.0-5a0c9d3
Linux C++ SDK (build): agonessdk-1.6.0-5a0c9d3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-5a0c9d3.zip

A preview of the website (the last 30 builds are retained):

https://5a0c9d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-5a0c9d3

markmandel

Let's do this!

google-oss-robot · 2020-04-21T22:00:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-21T22:00:17Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-04-21T22:18:29Z

Build Succeeded 👏

Build Id: e179d369-bdcc-43e9-a9e3-c5393a21ae70

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-4c3974a
image: gcr.io/agones-images/agones-sdk:1.6.0-4c3974a
image: gcr.io/agones-images/agones-ping:1.6.0-4c3974a
Linux C++ SDK (build): agonessdk-1.6.0-4c3974a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-4c3974a.zip

A preview of the website (the last 30 builds are retained):

https://4c3974a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1445/head:pr_1445 && git checkout pr_1445
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-4c3974a

* Pass FEATURE_GATES flag to e2e tests Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from markmandel and pooneh-m April 2, 2020 13:51

google-oss-robot added the size/S label Apr 2, 2020

aLekSer suggested changes Apr 2, 2020

View reviewed changes

test/e2e/main_test.go Outdated Show resolved Hide resolved

google-oss-robot assigned aLekSer Apr 2, 2020

akremsa force-pushed the exclude-featuregates branch from ccd824d to 6a89371 Compare April 2, 2020 14:03

akremsa requested a review from aLekSer April 2, 2020 14:05

akremsa force-pushed the exclude-featuregates branch 2 times, most recently from 32409b0 to 767d5c4 Compare April 2, 2020 14:20

akremsa force-pushed the exclude-featuregates branch from 767d5c4 to 0b2e3c0 Compare April 2, 2020 14:45

google-oss-robot added size/M and removed size/S labels Apr 2, 2020

aLekSer approved these changes Apr 2, 2020

View reviewed changes

google-oss-robot added the lgtm label Apr 2, 2020

markmandel reviewed Apr 2, 2020

View reviewed changes

test/e2e/main_test.go Outdated Show resolved Hide resolved

akremsa force-pushed the exclude-featuregates branch from 0b2e3c0 to d9702d6 Compare April 2, 2020 16:08

google-oss-robot added size/S and removed lgtm size/M labels Apr 2, 2020

akremsa force-pushed the exclude-featuregates branch from d9702d6 to 8c47647 Compare April 2, 2020 16:17

markmandel reviewed Apr 2, 2020

View reviewed changes

test/e2e/framework/framework.go Outdated Show resolved Hide resolved

markmandel reviewed Apr 20, 2020

View reviewed changes

build/Makefile Outdated Show resolved Hide resolved

akremsa force-pushed the exclude-featuregates branch from db126ad to 0bd2e7a Compare April 20, 2020 23:16

aLekSer reviewed Apr 21, 2020

View reviewed changes

build/Makefile Show resolved Hide resolved

aLekSer reviewed Apr 21, 2020

View reviewed changes

build/Makefile Show resolved Hide resolved

Fixed FEATURE_GATES flag in sdk tests

5a0c9d3

fix fix

akremsa force-pushed the exclude-featuregates branch from 0bd2e7a to 5a0c9d3 Compare April 21, 2020 06:54

aLekSer approved these changes Apr 21, 2020

View reviewed changes

google-oss-robot added the lgtm label Apr 21, 2020

akremsa requested a review from markmandel April 21, 2020 07:15

markmandel approved these changes Apr 21, 2020

View reviewed changes

google-oss-robot added the approved label Apr 21, 2020

Merge branch 'master' into exclude-featuregates

4c3974a

google-oss-robot removed the lgtm label Apr 21, 2020

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 21, 2020

markmandel added this to the 1.6.0 milestone Apr 21, 2020

markmandel merged commit eccc9d1 into googleforgames:master Apr 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass FEATURE_GATES flag to e2e tests #1445

Pass FEATURE_GATES flag to e2e tests #1445

akremsa commented Apr 2, 2020 •

edited

aLekSer left a comment

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer commented Apr 2, 2020

akremsa commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer left a comment

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer commented Apr 18, 2020 •

edited

agones-bot commented Apr 18, 2020

agones-bot commented Apr 20, 2020

akremsa commented Apr 20, 2020

markmandel Apr 20, 2020

agones-bot commented Apr 20, 2020

aLekSer left a comment

agones-bot commented Apr 21, 2020

markmandel left a comment

google-oss-robot commented Apr 21, 2020

google-oss-robot commented Apr 21, 2020

agones-bot commented Apr 21, 2020

Pass FEATURE_GATES flag to e2e tests #1445

Pass FEATURE_GATES flag to e2e tests #1445

Conversation

akremsa commented Apr 2, 2020 • edited

aLekSer left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer commented Apr 2, 2020

akremsa commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer commented Apr 18, 2020 • edited

agones-bot commented Apr 18, 2020

agones-bot commented Apr 20, 2020

akremsa commented Apr 20, 2020

markmandel Apr 20, 2020

Choose a reason for hiding this comment

agones-bot commented Apr 20, 2020

aLekSer left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 21, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 21, 2020

google-oss-robot commented Apr 21, 2020

agones-bot commented Apr 21, 2020

akremsa commented Apr 2, 2020 •

edited

aLekSer commented Apr 18, 2020 •

edited