Add a simple helm test #1449

aLekSer · 2020-04-04T18:42:58Z

This could be useful for Terraform configs check that installation
was completed, for example after switching to a new cluster.

Run helm test agones --cleanup to verify the deployment.

aLekSer · 2020-04-04T18:48:55Z

In Helm 3 there is an ability to use Batch Job instead of Pod in test-runner.yaml.
There would be great to have an option to run CRD manifest as helm test:

apiVersion: "agones.dev/v1"
kind: GameServer

We can add {{- if .Values.tests.enabled }} parameter as in this example https://github.com/hashicorp/consul-helm/blob/master/templates/tests/test-runner.yaml

An example of a failed run (for example ImagePullBackoff on Agones Controller when used wrong imageTag):

helm test agones --cleanup
RUNNING: agones-test-h5ulc
FAILED: agones-test-h5ulc, run `kubectl logs agones-test-h5ulc --namespace agones-system` for more info                                                                                                    
Error: 1 test(s) failed

Successful run:

helm test agones --cleanup
RUNNING: agones-test-uy3de
PASSED: agones-test-uy3de

agones-bot · 2020-04-04T18:54:27Z

Build Failed 😱

Build Id: 4c9454d0-19e1-4358-913d-9ce173188565

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-04T18:58:55Z

Build has failed because of absence of the image at the gcr.io/agones-images registry.

agones-bot · 2020-04-06T19:52:38Z

Build Failed 😱

Build Id: e614dd81-c296-408c-8e2f-a91899f954b2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-07T07:13:08Z

Build Failed 😱

Build Id: 51288b8b-a733-483b-9b35-8f1dc58fd868

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-07T07:42:05Z

Build Failed 😱

Build Id: 270569e7-a5d1-4a0c-ab60-4fbf3f3afe75

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-07T08:07:17Z

Build Succeeded 👏

Build Id: 8bec4e28-ea07-4bd2-bca5-a63a76c37614

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-fe1901e
image: gcr.io/agones-images/agones-sdk:1.5.0-fe1901e
image: gcr.io/agones-images/agones-ping:1.5.0-fe1901e
Linux C++ SDK (build): agonessdk-1.5.0-fe1901e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-fe1901e.zip

A preview of the website (the last 30 builds are retained):

https://fe1901e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-fe1901e

markmandel

LGTM, but probably should have some accompanying documentation? Probably in the Helm Installation section?

examples/crd-client/main.go

aLekSer · 2020-04-09T20:02:24Z

Yes, I will add this to the documentation.

markmandel · 2020-04-20T22:21:00Z

Gentle bump to add documentation.

agones-bot · 2020-04-21T09:04:25Z

Build Succeeded 👏

Build Id: 6ec4292c-a58b-49fa-85cf-5bc0ea4a6b80

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-a8891d7
image: gcr.io/agones-images/agones-sdk:1.6.0-a8891d7
image: gcr.io/agones-images/agones-ping:1.6.0-a8891d7
Linux C++ SDK (build): agonessdk-1.6.0-a8891d7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-a8891d7.zip

A preview of the website (the last 30 builds are retained):

https://a8891d7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-a8891d7

agones-bot · 2020-04-21T09:25:54Z

Build Succeeded 👏

Build Id: f700f771-8996-48a1-a680-46c2239da7f7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-21d38e7
image: gcr.io/agones-images/agones-sdk:1.6.0-21d38e7
image: gcr.io/agones-images/agones-ping:1.6.0-21d38e7
Linux C++ SDK (build): agonessdk-1.6.0-21d38e7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-21d38e7.zip

A preview of the website (the last 30 builds are retained):

https://21d38e7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-21d38e7

akremsa · 2020-04-21T09:47:07Z

examples/crd-client/main.go

-	fmt.Printf("New game servers' name is: %s", newGS.ObjectMeta.Name)
+	if viper.GetBool(isHelmTest) {
+		time.Sleep(1 * time.Second)
+		err = agonesClient.AgonesV1().GameServers(defaultNs).Delete(newGS.ObjectMeta.Name, nil) // nolint: errcheck


remove // nolint: errcheck

akremsa · 2020-04-21T10:02:22Z

examples/crd-client/main.go

+		time.Sleep(1 * time.Second)
+		err = agonesClient.AgonesV1().GameServers(defaultNs).Delete(newGS.ObjectMeta.Name, nil) // nolint: errcheck
+		if err != nil {
+			panic(err)


It is better to use panic from logrus here and above

akremsa · 2020-04-21T10:03:34Z

examples/crd-client/main.go

 	viper.SetDefault(gameServerImage, defaultImage)
 	runtime.Must(viper.BindEnv(gameServerImage))
-	viper.GetString(gameServerImage)
+
+	pflag.Bool(isHelmTest, false, "Is helm test - shutdown GameServer at the end of test. Defaults to false")


Can we rephrase - "Defines whether GameServer should be shut down at the end of the test or not"?

added your definition.

aLekSer · 2020-04-22T17:05:23Z

Fail in C# SDK conformance test:


/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly. [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018: System.IO.IOException: The process cannot access the file '/go/src/agones.dev/agones/sdks/csharp/sdk/bin/Release/netstandard2.0/AgonesSDK.deps.json' because it is being used by another process. [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at System.IO.FileStream.Init(FileMode mode, FileShare share) [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize) [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at System.IO.File.Create(String path) [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.ExecuteCore() [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
/usr/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
includes/sdk.mk:89: recipe for target 'run-sdk-command' failed
make[1]: *** [run-sdk-command] Error 1
includes/sdk.mk:85: recipe for target 'run-sdk-command-csharp' failed

agones-bot · 2020-04-22T17:23:32Z

Build Succeeded 👏

Build Id: 3bc82ec1-3569-4043-bf18-c096e606d567

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-d025a61
image: gcr.io/agones-images/agones-sdk:1.6.0-d025a61
image: gcr.io/agones-images/agones-ping:1.6.0-d025a61
Linux C++ SDK (build): agonessdk-1.6.0-d025a61-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-d025a61.zip

A preview of the website (the last 30 builds are retained):

https://d025a61-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-d025a61

agones-bot · 2020-04-22T17:27:14Z

Build Succeeded 👏

Build Id: dc3f378e-ff2a-4f55-ae36-7008b4e15f52

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-308cb54
image: gcr.io/agones-images/agones-sdk:1.6.0-308cb54
image: gcr.io/agones-images/agones-ping:1.6.0-308cb54
Linux C++ SDK (build): agonessdk-1.6.0-308cb54-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-308cb54.zip

A preview of the website (the last 30 builds are retained):

https://308cb54-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-308cb54

markmandel

Overall nice addition, just one thing to fixup I think.

markmandel · 2020-04-23T21:52:32Z

examples/crd-client/main.go

-	gameServerImage = "GAMESERVER_IMAGE"
+	gameServerImage      = "GAMESERVER_IMAGE"
+	isHelmTest           = "IS_HELM_TEST"
+	gameserversNamespace = "GAMESERVERS_NAMESPACE"

 	defaultImage = "gcr.io/agones-images/udp-server:0.19"


What was the motivation for hardcoding the image here? You were getting it as an environment variable, and it looks like you are still passing it in from the yaml below.

Seems like an env/arg value would be more flexible long term?

markmandel

Sorry, that was meant to be a comment, not an approval

This could be useful for Terraform configs check that installation was completed, for example after switching to a new cluster.

Described `helm test` command. Updated `crd-client` docs and version in yaml of example Job which creates a GameServer and also used by the test. Bump version of Agones in go.mod.

agones-bot · 2020-04-24T13:47:35Z

Build Succeeded 👏

Build Id: c5ff164d-c7e0-4869-addf-2a90ef25fa77

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-196fbd5
image: gcr.io/agones-images/agones-sdk:1.6.0-196fbd5
image: gcr.io/agones-images/agones-ping:1.6.0-196fbd5
Linux C++ SDK (build): agonessdk-1.6.0-196fbd5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-196fbd5.zip

A preview of the website (the last 30 builds are retained):

https://196fbd5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-196fbd5

agones-bot · 2020-04-24T14:03:45Z

Build Succeeded 👏

Build Id: 5bc3e8e5-e14a-4fdf-9898-41807252e931

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-f275fa4
image: gcr.io/agones-images/agones-sdk:1.6.0-f275fa4
image: gcr.io/agones-images/agones-ping:1.6.0-f275fa4
Linux C++ SDK (build): agonessdk-1.6.0-f275fa4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-f275fa4.zip

A preview of the website (the last 30 builds are retained):

https://f275fa4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-f275fa4

markmandel

Nice!

google-oss-robot · 2020-04-24T16:09:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-24T16:09:20Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-04-24T16:25:03Z

Build Succeeded 👏

Build Id: 908f4e44-1e46-4e6b-a4e0-824ffb365f80

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-5fa6d70
image: gcr.io/agones-images/agones-sdk:1.6.0-5fa6d70
image: gcr.io/agones-images/agones-ping:1.6.0-5fa6d70
Linux C++ SDK (build): agonessdk-1.6.0-5fa6d70-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-5fa6d70.zip

A preview of the website (the last 30 builds are retained):

https://5fa6d70-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1449/head:pr_1449 && git checkout pr_1449
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-5fa6d70

* Add a simple helm test This could be useful for Terraform configs check that installation was completed, for example after switching to a new cluster. * Add docs, import cleanup. Described `helm test` command. Updated `crd-client` docs and version in yaml of example Job which creates a GameServer and also used by the test. Bump version of Agones in go.mod. Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from dzlier-gcp and EricFortin April 4, 2020 18:43

google-oss-robot added the size/M label Apr 4, 2020

aLekSer force-pushed the helm-test branch from 0990e50 to 0e84668 Compare April 7, 2020 07:01

aLekSer force-pushed the helm-test branch from 0e84668 to 4d4d3c8 Compare April 7, 2020 07:30

google-oss-robot added size/L and removed size/M labels Apr 7, 2020

aLekSer force-pushed the helm-test branch from 4d4d3c8 to fe1901e Compare April 7, 2020 07:50

markmandel reviewed Apr 9, 2020

View reviewed changes

examples/crd-client/main.go Show resolved Hide resolved

markmandel added area/operations Installation, updating, metrics etc feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) kind/feature New features for Agones labels Apr 9, 2020

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 14, 2020

aLekSer force-pushed the helm-test branch from fe1901e to a8891d7 Compare April 21, 2020 08:48

aLekSer force-pushed the helm-test branch from a8891d7 to 21d38e7 Compare April 21, 2020 09:08

akremsa reviewed Apr 21, 2020

View reviewed changes

aLekSer force-pushed the helm-test branch from 21d38e7 to 9442ad9 Compare April 21, 2020 11:00

aLekSer force-pushed the helm-test branch 2 times, most recently from d025a61 to 308cb54 Compare April 22, 2020 17:08

markmandel approved these changes Apr 23, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 23, 2020

google-oss-robot added lgtm approved labels Apr 23, 2020

markmandel requested changes Apr 23, 2020

View reviewed changes

google-oss-robot removed lgtm approved labels Apr 23, 2020

Add a simple helm test

edbd78a

This could be useful for Terraform configs check that installation was completed, for example after switching to a new cluster.

aLekSer force-pushed the helm-test branch from 308cb54 to 196fbd5 Compare April 24, 2020 13:30

Add docs, import cleanup.

f275fa4

Described `helm test` command. Updated `crd-client` docs and version in yaml of example Job which creates a GameServer and also used by the test. Bump version of Agones in go.mod.

aLekSer force-pushed the helm-test branch from 196fbd5 to f275fa4 Compare April 24, 2020 13:46

markmandel approved these changes Apr 24, 2020

View reviewed changes

google-oss-robot added the lgtm label Apr 24, 2020

google-oss-robot added the approved label Apr 24, 2020

Merge branch 'master' into helm-test

5fa6d70

google-oss-robot removed the lgtm label Apr 24, 2020

markmandel merged commit 4ebd3b0 into googleforgames:master Apr 24, 2020

markmandel added this to the 1.6.0 milestone Apr 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a simple helm test #1449

Add a simple helm test #1449

aLekSer commented Apr 4, 2020

aLekSer commented Apr 4, 2020 •

edited

agones-bot commented Apr 4, 2020

aLekSer commented Apr 4, 2020 •

edited

agones-bot commented Apr 6, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 7, 2020

markmandel left a comment

aLekSer commented Apr 9, 2020

markmandel commented Apr 20, 2020

agones-bot commented Apr 21, 2020

agones-bot commented Apr 21, 2020

akremsa Apr 21, 2020

akremsa Apr 21, 2020

akremsa Apr 21, 2020

aLekSer Apr 21, 2020

aLekSer commented Apr 22, 2020

agones-bot commented Apr 22, 2020

agones-bot commented Apr 22, 2020

markmandel left a comment

markmandel Apr 23, 2020

markmandel left a comment

agones-bot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

markmandel left a comment

google-oss-robot commented Apr 24, 2020

google-oss-robot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

Add a simple helm test #1449

Add a simple helm test #1449

Conversation

aLekSer commented Apr 4, 2020

aLekSer commented Apr 4, 2020 • edited

agones-bot commented Apr 4, 2020

aLekSer commented Apr 4, 2020 • edited

agones-bot commented Apr 6, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 7, 2020

markmandel left a comment

Choose a reason for hiding this comment

aLekSer commented Apr 9, 2020

markmandel commented Apr 20, 2020

agones-bot commented Apr 21, 2020

agones-bot commented Apr 21, 2020

akremsa Apr 21, 2020

Choose a reason for hiding this comment

akremsa Apr 21, 2020

Choose a reason for hiding this comment

akremsa Apr 21, 2020

Choose a reason for hiding this comment

aLekSer Apr 21, 2020

Choose a reason for hiding this comment

aLekSer commented Apr 22, 2020

agones-bot commented Apr 22, 2020

agones-bot commented Apr 22, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 23, 2020

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 24, 2020

google-oss-robot commented Apr 24, 2020

agones-bot commented Apr 24, 2020

aLekSer commented Apr 4, 2020 •

edited

aLekSer commented Apr 4, 2020 •

edited