Code Gen and Stubs for updated Player Tracking #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is an update to the code generated from the Player Tracking proto updates, and the accompanying method stubs so that everything compiles and passes tests. Feature implementation work to come next! Work on googleforgames#1033
markmandel
added
the
area/user-experience
google-oss-robot
requested review from
devjgm,
roberthbailey and
steven-supersolid
|
Build Succeeded 👏 Build Id: df028411-562b-42bb-8fcb-0801fdb9ec18 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
steven-supersolid
approved these changes
Apr 24, 2020
|
Build Succeeded 👏 Build Id: 21167202-3ca1-4cbe-bdb9-5c02fded0bd8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Apr 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey, steven-supersolid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
* Regenerate gRPC code. * Code Gen and Stubs for updated Player Tracking This PR is an update to the code generated from the Player Tracking proto updates, and the accompanying method stubs so that everything compiles and passes tests. Feature implementation work to come next! Work on googleforgames#1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR is an update to the code generated from the Player Tracking
proto updates, and the accompanying method stubs so that everything
compiles and passes tests.
Which issue(s) this PR fixes:
Work on #1033
Special notes for your reviewer:
I deliberately split the codegen into one commit, and the stub work into another, to make it easier to review.
Feature implementation work to come next!