Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the multi-cluster allocation API version to stable #1540

Merged
merged 2 commits into from May 15, 2020

Conversation

pooneh-m
Copy link
Collaborator

What type of PR is this?
/kind breaking

What this PR does / Why we need it:
Changes the API version for multi-cluster allocation to stable.

Which issue(s) this PR fixes:
Closes #1534

@steven-supersolid
Copy link
Collaborator

I'm not sure why but the Node.js SDK package-lock.json file was changed so this should probably be removed from the review

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b5cae716-517c-4231-bcea-a540dc78adba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ab1a3ec5-f155-4fef-b9da-b4cb8edb2c70

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1540/head:pr_1540 && git checkout pr_1540
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-c472de0

@pooneh-m
Copy link
Collaborator Author

I'm not sure why but the Node.js SDK package-lock.json file was changed so this should probably be removed from the review

Thanks. I removed the package-lock.json.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d6ebcf4-a5d3-462e-80d0-62fa1577ddce

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1540/head:pr_1540 && git checkout pr_1540
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-415ee32

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dc45c39b-3ff5-4266-ab94-862865d8a80e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1540/head:pr_1540 && git checkout pr_1540
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-62a8a81

@pooneh-m pooneh-m merged commit d99c301 into googleforgames:master May 15, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
@markmandel markmandel added the kind/breaking Breaking change label May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the multi-cluster allocation API version to stable
6 participants