Creating a Fleet creates a GameServerSet #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😱 Build Id: 9e08eb3d-a08b-4b9a-af63-5120d777ee87 Build Logs |
markmandel
force-pushed
the
feature/fleet-no-update
branch
from
63314db
to
26c9365
Compare
|
@markmandel can be the error in this line? |
|
@fooock - the The test failed because I didn't run |
|
Build Succeeded 👏 Build Id: 7137844b-5f9f-4bd1-b6cc-2e90fc4b8bb5 The following development artifacts have been built, and will exist for the next 30 days:
|
|
ahhh ok, thanks for the explanation @markmandel . I didn't know it 😃 |
EricFortin
reviewed
Apr 13, 2018
| "Created GameServerSet %s", activeGsSet.ObjectMeta.Name) | ||
|
|
||
| } else { | ||
| // for now, we're ignoring any change to the template - will handle on the next PR |
There was a problem hiding this comment.
You want to support multiple game server set to implement things like rolling update?
EricFortin
reviewed
Apr 13, 2018
pkg/fleets/controller.go
Outdated
| return errors.Wrapf(err, "error updating replicas for gameserverset for fleet %s", fleet.ObjectMeta.Name) | ||
| } | ||
| c.recorder.Eventf(fleet, corev1.EventTypeNormal, "ScalingGameServerSet", | ||
| "Scaling GameServerSet %s to %d", gsSetCopy.ObjectMeta.Name, gsSetCopy.Spec.Replicas) |
There was a problem hiding this comment.
Could we add the old number too in the event so we know if it was scaling up or down?
EricFortin
approved these changes
Apr 13, 2018
All this commit is doing is create a GameServerSet when a Fleet is created. Also, if the Replicas in a Fleet are updated, then the owned GameServerSet's Replicas are also updated. For this commit, we are not worrying about handling updates to the Spec (e.g. new image) to the Fleet, and doing updates to a live Fleet, we are just concerned with scaling up and down. Parent ticket: googleforgames#70
markmandel
force-pushed
the
feature/fleet-no-update
branch
from
26c9365
to
745bffb
Compare
|
Build Succeeded 👏 Build Id: 45742169-9cab-4b8e-a93f-b88fd9d6498a The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this commit is doing is create a GameServerSet when a Fleet is created. Also, if the Replicas in
a Fleet are updated, then the owned GameServerSet's Replicas are also updated.
For this commit, we are not worrying about handling updates to the Spec (e.g. new image) to the Fleet,
and doing updates to a live Fleet, we are just concerned with scaling up and down.
Parent ticket: #70