Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin npm autoprefixer package for site generation #1818

Merged
merged 2 commits into from Sep 15, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The 10.0.0 release of autoprefixer broke site generation, so pinning the version to a 9.x.x release.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

This will unclog CI as well.

The 10.0.0 release of autoprefixer broke site generation, so pinning the
version to a 9.x.x release.

This will unclog CI as well.
@markmandel markmandel added kind/bug These are bugs. area/site The website itself - including redirects, styling, search, etc labels Sep 15, 2020
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point this is going to come back and bite us if we forget to ever check to see if they fix things (or figure out how to upgrade to post 10.0.0) but this seems like a reasonable short term fix. Can you open a tracking bug to get back onto a non-pinned version in the future?

@markmandel
Copy link
Member Author

Should we create a ticket to update this dependency -- or should the ticket be to upgrade hugo+docsy, and therefore the whole suite of dependencies?

(I expect at some point Hugo/Docsy will work out how to work with the new version)

@roberthbailey
Copy link
Member

Either way is fine, just as long as we don't stay pinned forever and forget about it.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aLekSer,markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec2e55da-7959-4ff2-b67c-77cb5a6bf28e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1818/head:pr_1818 && git checkout pr_1818
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-339c004

@aLekSer aLekSer merged commit 25ed44e into googleforgames:master Sep 15, 2020
@markmandel markmandel deleted the bug/site-static branch September 15, 2020 20:42
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
The 10.0.0 release of autoprefixer broke site generation, so pinning the
version to a 9.x.x release.

This will unclog CI as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants