Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node.js dependencies #1868

Merged
merged 1 commit into from Oct 26, 2020
Merged

update node.js dependencies #1868

merged 1 commit into from Oct 26, 2020

Conversation

steven-supersolid
Copy link
Collaborator

@steven-supersolid steven-supersolid commented Oct 25, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Updates Node.js SDK dependencies to address security warning

Special notes for your reviewer:

@google-cla google-cla bot added the cla: yes label Oct 25, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 140e3cea-e27b-4712-851c-2d08bf1f35f5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1868/head:pr_1868 && git checkout pr_1868
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-433da51

markmandel
markmandel approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY NO MORE WARNINGS.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit e3d62c7 into googleforgames:master Oct 26, 2020
@markmandel markmandel added area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 26, 2020
@markmandel markmandel added this to the 1.10.0 milestone Oct 26, 2020
@steven-supersolid steven-supersolid deleted the node-deps branch February 4, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/security Issues pertaining to security cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steven-supersolid @agones-bot @google-oss-robot @markmandel