Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unreal SDK] Added a response code check to some functions #1870

Merged
merged 2 commits into from Oct 28, 2020

Conversation

dotcom
Copy link
Contributor

@dotcom dotcom commented Oct 27, 2020

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:
Added a response code check to some functions about Unreal SDK.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4f5068d7-ee3a-4272-ad07-c1c0fbc6f2ae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1870/head:pr_1870 && git checkout pr_1870
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-e1d33b9

Copy link
Contributor

@domgreen domgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like a good addition 👍

@google-oss-robot
Copy link

@domgreen: changing LGTM is restricted to collaborators

In response to this:

LGTM

Looks like a good addition 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markmandel
Copy link
Member

Only questions I have - is this a breaking change?

Other than that, I'm happy to push this through 👍

@dotcom
Copy link
Contributor Author

dotcom commented Oct 28, 2020

@markmandel
No. The user interface has not changed. It can still be used. This makes it less confusing for the user.
Users can execute an Error callback in case of a bad response code in addition to communication errors.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seal of approval

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, dotcom, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Oct 28, 2020
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b2a5f4aa-c01b-43da-b11f-c0f96daf9f30

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1870/head:pr_1870 && git checkout pr_1870
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-7ec735f

@markmandel markmandel merged commit c2344dc into googleforgames:master Oct 28, 2020
@markmandel markmandel added this to the 1.10.0 milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants