Adding rest to allocation endpoint #1902

kdima · 2020-11-17T17:59:34Z

/kind feature

What this PR does / Why we need it:
This should solve #1495

Which issue(s) this PR fixes:
Closes #1495

Special notes for your reviewer:
We are running both grpc and rest on the same port so there is no need to update the services yaml.

google-cla · 2020-11-17T17:59:39Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-17T18:01:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

agones-bot · 2020-11-17T18:07:59Z

Build Failed 😱

Build Id: eab6e3e2-87b5-4921-aea0-338604d8d9aa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-11-17T18:09:24Z

Build Failed 😱

Build Id: 0d181954-aa13-4bdf-904c-7d58d86cd772

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Looks like you are getting caught on some linting issues - will come back again when you get this sorted.

But looks like a nice addition 🔥

Only other thought - would need to have some documentation here as well: https://agones.dev/site/docs/advanced/allocator-service/ (maybe also an example on multi-cluster as well).

But since this is draft, that may be your intent for when it's ready to go 👍

cmd/allocator/main.go

markmandel · 2020-11-17T18:12:44Z

cmd/allocator/main.go

@@ -64,6 +63,18 @@ const (
 	sslPort = "8443"
 )

+// grpcHandlerFunc returns an http.Handler that delegates to grpcServer on incoming gRPC
+// connections or otherHandler otherwise. Copied from https://github.com/philips/grpc-gateway-example.
+func grpcHandlerFunc(grpcServer http.Handler, otherHandler http.Handler) http.Handler {


Oh that's clever!

@roberthbailey we probably should have done this on the sdk sidecar! oh well!

The other option is apparently to use a dedicated muxer but since Agones doesn't have one pulled in atm I figured it is easier to use this approach.

Is this backwards compatible? I'm wondering if we could take the existing grpc port on the sidecar and add a similar handler to handle both grpc and http.

If so, we could migrate the default ports to be the same for both and then deprecate the ability to select a separate http port. After a grace period we could remove the ability to select the http port.

My understanding is that it is backwards compatible in the sense that grpc clients will not be aware of the change when grpcHandlerFunc is added. I double checked it by running the example allocator-client.

agones-bot · 2020-11-17T18:22:26Z

Build Failed 😱

Build Id: b3424705-b609-4ee9-a06f-df628c44bab2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-11-17T23:41:27Z

Build Succeeded 👏

Build Id: c4be2e7c-8a92-464b-aaa8-9496a7f411ed

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-ecbd1c2
image: gcr.io/agones-images/agones-sdk:1.11.0-ecbd1c2
image: gcr.io/agones-images/agones-ping:1.11.0-ecbd1c2
Linux C++ SDK (build): agonessdk-1.11.0-ecbd1c2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-ecbd1c2.zip

A preview of the website (the last 30 builds are retained):

https://ecbd1c2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-ecbd1c2

kdima · 2020-11-18T14:40:25Z

Thanks for the review!

Only other thought - would need to have some documentation here as well: https://agones.dev/site/docs/advanced/allocator-service/ (maybe also an example on multi-cluster as well).

I have added docs, but not sure if it is sufficient.

agones-bot · 2020-11-18T14:52:05Z

Build Failed 😱

Build Id: 844490f9-6eaa-472a-bc56-4951d0b09461

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-11-18T15:07:10Z

Build Failed 😱

Build Id: f5865c7a-e709-4f92-8c41-fcccc84f0123

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-11-18T15:56:27Z

Build Succeeded 👏

Build Id: d3af07ac-61e8-4f9b-98b6-6813d518019f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-b944516
image: gcr.io/agones-images/agones-sdk:1.11.0-b944516
image: gcr.io/agones-images/agones-ping:1.11.0-b944516
Linux C++ SDK (build): agonessdk-1.11.0-b944516-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-b944516.zip

A preview of the website (the last 30 builds are retained):

https://b944516-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-b944516

agones-bot · 2020-11-19T11:01:18Z

Build Succeeded 👏

Build Id: fe7720e5-6abd-4c4a-a276-ae84575cda33

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-8fa3f9d
image: gcr.io/agones-images/agones-sdk:1.11.0-8fa3f9d
image: gcr.io/agones-images/agones-ping:1.11.0-8fa3f9d
Linux C++ SDK (build): agonessdk-1.11.0-8fa3f9d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-8fa3f9d.zip

A preview of the website (the last 30 builds are retained):

https://8fa3f9d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-8fa3f9d

markmandel

This is awesome - can't wait to have it in. 🍰 Some comments and questions.

markmandel · 2020-11-20T00:42:48Z

cmd/allocator/main.go

-		err := grpcServer.Serve(listener)
-		logger.WithError(err).Fatal("allocation service crashed")
+		err = server.ListenAndServeTLS("", "")
+		logger.WithError(err).Fatal("could not listen on REST")


I feel like this error message could be better somehow... 🤔

How about?

Suggested change

logger.WithError(err).Fatal("could not listen on REST")

logger.WithError(err).Fatal("Unable to start HTTPS listener")

WDYT?

cmd/allocator/main.go

site/content/en/docs/Advanced/allocator-service.md

markmandel · 2020-11-20T00:57:34Z

site/content/en/docs/Advanced/allocator-service.md

+
+curl --key ${KEY_FILE} --cert ${CERT_FILE} --cacert ${TLS_CA_FILE} -H "Content-Type: application/json" --data '{"namespace":"'${NAMESPACE}'"}' https://${EXTERNAL_IP}/gameserverallocation -XPOST
+```
+


Is it worth providing a sample output? It might be nice to know the format of the JSON?

Can you factor out the section for setting the env variable in a separate section before gRPC and REST?

I have modified both allocator-service.md and multi-cluster-allocation.md to have a factored out variable setting. Let me know if you think it looks ok now?
I think as a user I don't mind a bit of code duplication in the example scripts as it allows me to copy paste the script from documentation and have it run straight away, whereas with factored out env setting I need to do 2 steps.

eventually the code snippets will be turned into a script for running multiple times but having a clear documentation on the code snippets may make it easier for the first timer to understand the flow. @markmandel do you have any recommendation on this? I am not experienced in the user experience for documentation.

Looks good to me - I get it 👍

markmandel · 2020-11-20T00:58:06Z

site/content/en/docs/Advanced/multi-cluster-allocation.md

+If using REST use
+
+```bash
+go run examples/allocator-client/main.go --ip ${EXTERNAL_IP} \


Should this be curl if using REST? (Also, we'll need to wrap it in the feature shortcode like above please.)

Good catch. Fixed

markmandel · 2020-11-20T00:58:21Z

test/e2e/allocator_test.go

@@ -99,6 +103,68 @@ func TestAllocator(t *testing.T) {
 	assert.NoError(t, err)
 }

+func TestRestAllocator(t *testing.T) {


Yay! E2E test!

agones-bot · 2020-11-20T16:30:14Z

Build Succeeded 👏

Build Id: 70d5b188-aba6-4e9a-abae-6c1ba34f7c2f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-e11a001
image: gcr.io/agones-images/agones-sdk:1.11.0-e11a001
image: gcr.io/agones-images/agones-ping:1.11.0-e11a001
Linux C++ SDK (build): agonessdk-1.11.0-e11a001-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-e11a001.zip

A preview of the website (the last 30 builds are retained):

https://e11a001-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-e11a001

agones-bot · 2020-11-20T16:35:17Z

Build Succeeded 👏

Build Id: 22450df1-c25a-4fd3-a0d4-84872a0b16e2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-eba1cc1
image: gcr.io/agones-images/agones-sdk:1.11.0-eba1cc1
image: gcr.io/agones-images/agones-ping:1.11.0-eba1cc1
Linux C++ SDK (build): agonessdk-1.11.0-eba1cc1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-eba1cc1.zip

A preview of the website (the last 30 builds are retained):

https://eba1cc1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-eba1cc1

markmandel

This LGTM! Happy to approve once @pooneh-m has a chance to review. 👍

pooneh-m

Thanks for the change. I left some minor comments, but looks pretty good.

pooneh-m · 2020-11-25T17:55:53Z

site/content/en/docs/Advanced/multi-cluster-allocation.md

+```bash
+#!/bin/bash
+
+NAMESPACE=default # replace with any namespace


The note before the scripts says: Follow [agones-allocator]({{< relref "allocator-service.md#send-allocation-request">}}) to set the environment variables.

You can remove the section to add the environment variables for REST similar to gRPC sample or remove the note and add a script to set the env variables before the gRPC/REST calls.

pooneh-m · 2020-11-25T19:31:46Z

site/content/en/docs/Advanced/allocator-service.md

+
+curl --key ${KEY_FILE} --cert ${CERT_FILE} --cacert ${TLS_CA_FILE} -H "Content-Type: application/json" --data '{"namespace":"'${NAMESPACE}'"}' https://${EXTERNAL_IP}/gameserverallocation -XPOST
+```
+


Can you factor out the section for setting the env variable in a separate section before gRPC and REST?

pooneh-m · 2020-11-25T19:35:53Z

cmd/allocator/main.go

-		cfg.ClientAuth = tls.RequireAnyClientCert
-		cfg.VerifyPeerCertificate = h.verifyClientCertificate
-	}
-
 	// Add options for creds and  OpenCensus stats handler to enable stats and tracing.


Update the documentation to remove options for creds?

Not sure what you mean. Do you mean that I should remove/change the comment that says:
// Add options for creds and OpenCensus stats handler to enable stats and tracing.
or that I need to document changes to options?
I don't think this change changes the command line options as h.tlsDisabled and h.mTLSDisabled are still used.

the documentation says it adds options for creds and ... my comment was to remote certs from the doc as you removed the grpc.Creds(credentials.NewTLS(cfg)),. So change it to // Add an option for OpenCensus stats handler to enable stats and tracing.

Makes sense! Fixed it now.

pooneh-m · 2020-11-25T20:07:04Z

cmd/allocator/main.go

+func grpcHandlerFunc(grpcServer http.Handler, otherHandler http.Handler) http.Handler {
+	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// This is a partial recreation of gRPC's internal checks https://github.com/grpc/grpc-go/pull/514/files#diff-95e9a25b738459a2d3030e1e6fa2a718R61
+		if r.ProtoMajor == 2 && strings.Contains(r.Header.Get("Content-Type"), "application/grpc") {


I am still not clear why ProtoMajor == 2 and not 3 for the gRPC server.
Can you please add more documentations?

ProtoMajor refers to the HTTP protocol major version part. We are checking if request is HTTP/1.1 or HTTP/2. Will add that as a comment to the code.

agones-bot · 2020-11-26T14:28:13Z

Build Succeeded 👏

Build Id: f502201d-f731-48f6-87ec-5f47a4d652d5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-1bd593c
image: gcr.io/agones-images/agones-sdk:1.11.0-1bd593c
image: gcr.io/agones-images/agones-ping:1.11.0-1bd593c
Linux C++ SDK (build): agonessdk-1.11.0-1bd593c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-1bd593c.zip

A preview of the website (the last 30 builds are retained):

https://1bd593c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-1bd593c

pooneh-m · 2020-11-29T22:49:18Z

cmd/allocator/main.go

-		cfg.ClientAuth = tls.RequireAnyClientCert
-		cfg.VerifyPeerCertificate = h.verifyClientCertificate
-	}
-
 	// Add options for creds and  OpenCensus stats handler to enable stats and tracing.


the documentation says it adds options for creds and ... my comment was to remote certs from the doc as you removed the grpc.Creds(credentials.NewTLS(cfg)),. So change it to // Add an option for OpenCensus stats handler to enable stats and tracing.

pooneh-m · 2020-11-29T22:52:47Z

site/content/en/docs/Advanced/allocator-service.md

+# In case of MacOS replace "base64 -d" with "base64 -D"
+kubectl get secret allocator-client.default -n "${NAMESPACE}" -ojsonpath="{.data.tls\.crt}" | base64 -d > "${CERT_FILE}"
+kubectl get secret allocator-client.default -n "${NAMESPACE}" -ojsonpath="{.data.tls\.key}" | base64 -d > "${KEY_FILE}"
+kubectl get secret allocator-tls-ca -n agones-system -ojsonpath="{.data.tls-ca\.crt}" | base64 -d > "${TLS_CA_FILE}"


Can we move L176-L178 to the section above as they are common between the two?

Moved the lines and renamed the section to be: Reuse following snippet for both grpc and rest examples:
Not sure whether this is good heading for it so open to suggestions.

Maybe something like Set the environment variables and store the client secrets before allocating using gRPC or REST APIs?

Also, please make the same change for the multi-cluster-allocation.md file to keep them in sync.

pooneh-m · 2020-11-29T23:00:44Z

site/content/en/docs/Advanced/allocator-service.md

+
+curl --key ${KEY_FILE} --cert ${CERT_FILE} --cacert ${TLS_CA_FILE} -H "Content-Type: application/json" --data '{"namespace":"'${NAMESPACE}'"}' https://${EXTERNAL_IP}/gameserverallocation -XPOST
+```
+


eventually the code snippets will be turned into a script for running multiple times but having a clear documentation on the code snippets may make it easier for the first timer to understand the flow. @markmandel do you have any recommendation on this? I am not experienced in the user experience for documentation.

agones-bot · 2020-11-30T17:26:00Z

Build Succeeded 👏

Build Id: dbc84e75-56cf-422a-a31c-3148daf7ae30

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-cd385f8
image: gcr.io/agones-images/agones-sdk:1.11.0-cd385f8
image: gcr.io/agones-images/agones-ping:1.11.0-cd385f8
Linux C++ SDK (build): agonessdk-1.11.0-cd385f8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-cd385f8.zip

A preview of the website (the last 30 builds are retained):

https://cd385f8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-cd385f8

agones-bot · 2020-12-01T11:00:33Z

Build Succeeded 👏

Build Id: e1bf2947-bd58-4ad2-8b8d-fc4ff5fa29dd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-c3bd3b4
image: gcr.io/agones-images/agones-sdk:1.11.0-c3bd3b4
image: gcr.io/agones-images/agones-ping:1.11.0-c3bd3b4
Linux C++ SDK (build): agonessdk-1.11.0-c3bd3b4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-c3bd3b4.zip

A preview of the website (the last 30 builds are retained):

https://c3bd3b4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-c3bd3b4

google-oss-robot · 2020-12-01T18:14:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdima, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-12-01T18:14:17Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-12-01T18:35:15Z

Build Succeeded 👏

Build Id: b6556ddb-07da-4d5b-9743-e8406d0a0d2c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.11.0-e34243c
image: gcr.io/agones-images/agones-sdk:1.11.0-e34243c
image: gcr.io/agones-images/agones-ping:1.11.0-e34243c
Linux C++ SDK (build): agonessdk-1.11.0-e34243c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.11.0-e34243c.zip

A preview of the website (the last 30 builds are retained):

https://e34243c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1902/head:pr_1902 && git checkout pr_1902
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-e34243c

1495 rest allocation endpoint

35f2bc1

google-oss-robot added the do-not-merge/work-in-progress label Nov 17, 2020

google-cla bot added the cla: no label Nov 17, 2020

google-oss-robot requested review from cyriltovena and pooneh-m November 17, 2020 17:59

google-oss-robot added the size/L label Nov 17, 2020

fixes

fbb94e3

fixes

ecbd1c2

google-cla bot added cla: yes and removed cla: no labels Nov 17, 2020

markmandel reviewed Nov 17, 2020

View reviewed changes

docs

5b451df

kdima marked this pull request as ready for review November 18, 2020 14:39

google-oss-robot removed the do-not-merge/work-in-progress label Nov 18, 2020

rename

272d485

minor fix

b944516

Merge branch 'master' into feature/allocator-rest-gateway

8fa3f9d

markmandel reviewed Nov 20, 2020

View reviewed changes

cleanup

c808770

kdima requested review from markmandel and roberthbailey November 20, 2020 18:19

markmandel reviewed Nov 24, 2020

View reviewed changes

pooneh-m reviewed Nov 25, 2020

View reviewed changes

docs

1bd593c

kdima requested a review from pooneh-m November 27, 2020 18:09

pooneh-m reviewed Nov 29, 2020

View reviewed changes

docs

cd385f8

kdima requested review from pooneh-m and markmandel November 30, 2020 17:05

fixes

c3bd3b4

pooneh-m approved these changes Dec 1, 2020

View reviewed changes

google-oss-robot assigned pooneh-m Dec 1, 2020

google-oss-robot added the lgtm label Dec 1, 2020

google-oss-robot added the approved label Dec 1, 2020

Merge branch 'master' into feature/allocator-rest-gateway

e34243c

google-oss-robot removed the lgtm label Dec 1, 2020

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Dec 1, 2020

markmandel added this to the 1.11.0 milestone Dec 1, 2020

markmandel merged commit e97620a into googleforgames:master Dec 1, 2020

roberthbailey mentioned this pull request Sep 14, 2021

Allow the allocator service to use the go http/2 server #2263

Closed

	logger.WithError(err).Fatal("could not listen on REST")
	logger.WithError(err).Fatal("Unable to start HTTPS listener")


		curl --key ${KEY_FILE} --cert ${CERT_FILE} --cacert ${TLS_CA_FILE} -H "Content-Type: application/json" --data '{"namespace":"'${NAMESPACE}'"}' https://${EXTERNAL_IP}/gameserverallocation -XPOST
		```

Adding rest to allocation endpoint #1902

Adding rest to allocation endpoint #1902

Conversation

kdima commented Nov 17, 2020

google-cla bot commented Nov 17, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Nov 17, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

agones-bot commented Nov 17, 2020

agones-bot commented Nov 17, 2020

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 17, 2020

agones-bot commented Nov 17, 2020

kdima commented Nov 18, 2020

agones-bot commented Nov 18, 2020

agones-bot commented Nov 18, 2020

agones-bot commented Nov 18, 2020

agones-bot commented Nov 19, 2020

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 20, 2020

agones-bot commented Nov 20, 2020

markmandel left a comment

Choose a reason for hiding this comment

pooneh-m left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 30, 2020

agones-bot commented Dec 1, 2020

google-oss-robot commented Dec 1, 2020

google-oss-robot commented Dec 1, 2020

agones-bot commented Dec 1, 2020