Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev tooling kubectl to 1.18 #1989

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

For both the build image and the e2e image.

Which issue(s) this PR fixes:

Work on #1971

Special notes for your reviewer:

N/A

For both the build image and the e2e image.

Work on googleforgames#1971
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/breaking Breaking change labels Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 05e05acc-8bf4-4bdb-8571-2594f7fdd0ec

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Some e2e tests failed:

--- FAIL: TestGameServerAllocationMetaDataPatch (167.70s)
    gameserverallocation_test.go:283: 
        	Error Trace:	gameserverallocation_test.go:283
        	Error:      	timed out waiting for the condition
        	Test:       	TestGameServerAllocationMetaDataPatch

--- FAIL: TestSDKSetLabel (181.58s)
    gameserver_test.go:94: 
        	Error Trace:	gameserver_test.go:94
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestSDKSetLabel

--- FAIL: TestGameServerShutdown (318.05s)
    gameserver_test.go:658: 
        	Error Trace:	gameserver_test.go:658
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestGameServerShutdown

Will rerun and see if it's flaky, or a real issue.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 64ec6390-f8a1-4b72-ae94-71247d99f54a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Failed again. Will need to investigate.

--- FAIL: TestGameServerTcpUdpProtocol (181.19s)
    gameserver_test.go:748: Could not ping TCP GameServer: dial tcp 34.82.222.150:7675: connect: connection timed out

Will try one more time just for giggles.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ebe3d6c6-0600-45fb-8b44-bbab82b6662d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

At least this seems consistent:

--- FAIL: TestGameServerTcpUdpProtocol (163.87s)
    gameserver_test.go:748: Could not ping TCP GameServer: dial tcp 35.247.81.255:7537: connect: connection timed out
time="2021-02-10 05:10:24.435" level=info msg="fleet simple-fleet-grlfq has 10/10 ready replicas"

@markmandel
Copy link
Member Author

🤦 I know why it's failing. The tcp firewall rule is gone. Hmnn, that's odd.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3e2e5bd8-304c-4866-aea0-7067e5d41c8a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1989/head:pr_1989 && git checkout pr_1989
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-d386c6a

@markmandel markmandel requested review from roberthbailey and removed request for EricFortin February 10, 2021 22:00
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 54c9d1b into googleforgames:main Feb 10, 2021
@markmandel markmandel deleted the upgrade/kubectl-1.18.x branch February 10, 2021 22:07
@markmandel markmandel added this to the 1.13.0 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/breaking Breaking change lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants