updating debian image to bullseye

[SaitejaTamma]

updating debian image to latest

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[google-oss-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaitejaTamma
To complete the pull request process, please assign dzlier-gcp after the PR has been reviewed.
You can assign the PR to them by writing /assign @dzlier-gcp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Failed 😱

Build Id: 3d3ac076-51dc-44fe-890b-d8f9fae0107d

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[chaodaiG]

Just for testing #2347 , expecting prow app leaving a cat image
/meow

[google-oss-prow]

@chaodaiG:

In response to this:

Just for testing #2347 , expecting prow app leaving a cat image
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roberthbailey]

I think it makes more sense to update to bullseye than latest. Right now they point to the same thing:

bullseye: https://hub.docker.com/layers/debian/library/debian/bullseye/images/sha256-7448716003c940a5adbf4ddedf0486ecdfeb18fbcd8f13c700886ba0d9b82318?context=explore

latest: https://hub.docker.com/layers/debian/library/debian/latest/images/sha256-7448716003c940a5adbf4ddedf0486ecdfeb18fbcd8f13c700886ba0d9b82318?context=explore

But this gives us more control over when we upgrade to bookworm (instead of finding out during a random CI build).

[roberthbailey]

CI failure:

installing current release
# if IMAGE_PULL_SECRET_FILE is specified, create the agones-system namespace and install the secret
\
	helm upgrade --install --atomic --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.19.0-fc803d6,agones.image.registry=gcr.io/agones-images \
	--set agones.image.controller.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.image.controller.pullSecret= \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.service.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="PlayerTracking=true&SDKWatchSendOnExecute=false&NodeExternalDNS=true&StateAllocationFilter=true&PlayerAllocationFilter=true&CustomFasSyncInterval=true" \
	--set agones.allocator.service.loadBalancerIP=35.199.162.54 \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Error: UPGRADE FAILED: another operation (install/upgrade/rollback) is in progress
make: *** [install] Error 1

[roberthbailey]

xref: #2356

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaitejaTamma
To complete the pull request process, please assign dzlier-gcp after the PR has been reviewed.
You can assign the PR to them by writing /assign @dzlier-gcp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[roberthbailey]

nit: please remove trailing whitespace.

[agones-bot]

Build Failed 😱

Build Id: b011a5d5-64d6-4ab4-bf30-0d6927100cc9

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: dc294d22-586e-4a62-843d-d4785ad138e5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Should we update this one as well:

agones/build/build-sdk-images/tool/base/Dockerfile

Line 20 in e048859

FROM debian:buster

[roberthbailey]

I see a few other places where we use buster in the example images but we can do those separately: https://github.com/googleforgames/agones/search?l=Dockerfile&q=buster

[markmandel]

Should we update this one as well:

agones/build/build-sdk-images/tool/base/Dockerfile

Line 20 in e048859

FROM debian:buster

+1 on this. If we are going to update the build tooling, might as well do it all? (Unless @SaitejaTamma you specifically wanted to do it separately?)

As a side note: it would be handy if we reference done in the PR by issue # in the description.

If not closing, a description of "Work on #2224" would make looking up issues for PRs super convenient. 👍🏻

[agones-bot]

Build Failed 😱

Build Id: ccdf4a98-4685-4662-b0d8-1693434bbc54

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Looks like the update is breaking compilation of grpc.

[CXX]     Compiling src/core/lib/gpr/env_posix.cc
[CXX]     Compiling src/core/lib/gpr/env_windows.cc
[CXX]     Compiling src/core/lib/gpr/host_port.cc
[CXX]     Compiling src/core/lib/gpr/log.cc
[CXX]     Compiling src/core/lib/gpr/log_android.cc
[CXX]     Compiling src/core/lib/gpr/log_linux.cc
[CXX]     Compiling src/core/lib/gpr/log_posix.cc
[CXX]     Compiling src/core/lib/gpr/log_windows.cc
src/core/lib/gpr/log_linux.cc:43:13: error: ambiguating new declaration of 'long int gettid()'
   43 | static long gettid(void) { return syscall(__NR_gettid); }
      |             ^~~~~~
In file included from /usr/include/unistd.h:1170,
                 from src/core/lib/gpr/log_linux.cc:41:
/usr/include/x86_64-linux-gnu/bits/unistd_ext.h:34:16: note: old declaration '__pid_t gettid()'
   34 | extern __pid_t gettid (void) __THROW;
      |                ^~~~~~
src/core/lib/gpr/log_linux.cc:43:13: warning: 'long int gettid()' defined but not used [-Wunused-function]
   43 | static long gettid(void) { return syscall(__NR_gettid); }
      |             ^~~~~~
make: *** [Makefile:2916: /var/local/git/grpc/objs/opt/src/core/lib/gpr/log_linux.o] Error 1
make: *** Waiting for unfinished jobs....
The command '/bin/sh -c git clone -b $GRPC_RELEASE_TAG --depth=5 https://github.com/grpc/grpc /var/local/git/grpc &&     cd /var/local/git/grpc &&     git submodule update --init &&     echo "--- installing protobuf ---" &&     cd third_party/protobuf &&     ./autogen.sh && ./configure --enable-shared &&     make -j4 && make install && make clean && ldconfig &&     export CFLAGS=-Wno-error && export CXXFLAGS=-Wno-error &&     echo "--- installing grpc ---" &&     cd /var/local/git/grpc &&     make -j4 && make install && make clean && ldconfig' returned a non-zero code: 2
make[2]: *** [includes/sdk.mk:101: build-build-sdk-image-base] Error 2
make[2]: Leaving directory '/workspace/build'
make[1]: *** [includes/build-image.mk:54: ensure-image] Error 2
make[1]: Leaving directory '/workspace/build'
make: *** [includes/sdk.mk:119: ensure-build-sdk-image-base] Error 2

Seeing lots of similar things over on tensorflow, when doing some Googling:
tensorflow/tensorflow#33758

[roberthbailey]

@SaitejaTamma - are you still working on this PR?

[agones-bot]

Build Failed 😱

Build Id: 1a6a0806-1229-4f72-b758-5c8fbbab00e1

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: ade2108d-b464-4e1b-8418-b28d64605ff5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.