Add helm setting for leader election #3051

chiayi · 2023-03-29T17:17:04Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
This PR adds helm config for controller leader election

Which issue(s) this PR fixes:
Work on #2797

Special notes for your reviewer:

agones-bot · 2023-03-29T17:26:48Z

Build Failed 😱

Build Id: aca33ce0-c17a-4671-a2d4-5f5585500dc0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2023-03-29T17:26:08Z

install/helm/agones/templates/_helpers.tpl

+Derives the replica number for agones-controller based on current helm and feature flag settings.
+*/}}
+{{- define "agones.controller.replica" -}}


I forgot this was landing all in controller.yaml, any reason we can't just inline the logic rather than adding the helper? I think if you inline it at e.g. line 16 in controller.yaml, you don't even need a define, it just becomes a matter of setting $controllerReplicas.

I moved it to inline, please take a look.

zmerlynn · 2023-03-29T17:28:10Z

install/helm/agones/templates/controller.yaml

@@ -13,6 +13,7 @@
 # limitations under the License.

 {{- $featureGates := include "agones.featureGates" . | fromYaml }}
+{{- $controllerReplica := include "agones.controller.replica" . }}


nit: I would call this controllerReplicas (plural), or just replicas. You're in controller.yaml, the controller prefix is kind of redundant.

Done, changed to just replicas

install/helm/agones/templates/controller.yaml

install/helm/agones/templates/_helpers.tpl

install/helm/agones/values.yaml

agones-bot · 2023-03-29T19:14:18Z

Build Failed 😱

Build Id: 30d8ce46-ff70-492d-927f-28500727646d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn

Really close!

install/helm/agones/templates/_helpers.tpl

zmerlynn · 2023-03-29T19:54:50Z

install/helm/agones/templates/controller.yaml

@@ -13,6 +13,10 @@
 # limitations under the License.

 {{- $featureGates := include "agones.featureGates" . | fromYaml }}
+{{- $replicas := .Values.agones.controller.replicas }}


we talked offline about just passing this through, but since you rely on this being an int (which I wasn't thinking about during standup), you probably need to cast it here - and maybe validate it's > 0?

Do we have to ensure that replicas is an int here? It would fail the gt checks if it isn't an int.
But I guess that would mean relying on the helm check to give an typing error instead of us stating the error earlier. This also applies to validating if replicas is greater than 0, it will also give an typing error when comparing with a 0.

It looks like the build break you just had was because it wasn't cast to an int already - that's why I was suggesting it here (it probably comes in as string?) Maybe I'm wrong. Whichever way works - happy if helm validates it and we can skip code.

I see I see. You are correct, there is a need to cast to int. This also means that we would need to check if values is 0 once it's casted. What is the behavior we want when the value is set to 0? Do we want it to default to 1?

site/content/en/docs/Installation/Install Agones/helm.md

agones-bot · 2023-03-29T21:04:28Z

Build Failed 😱

Build Id: de679343-bf8f-4bf5-8930-e74f304c30fe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn

LGTM. Fix some nits, take off the WIP and I'll get it merged.

install/helm/agones/templates/controller.yaml

agones-bot · 2023-03-30T02:15:41Z

Build Failed 😱

Build Id: a82c6dc9-21ed-4e47-9af3-cdb38f9c4956

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-30T17:04:42Z

Build Failed 😱

Build Id: 98393d84-ebed-4e59-be6e-54c75d552448

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2023-03-30T18:04:18Z

Your code LGTM, now just get it past the @agones-bot guantlet.

agones-bot · 2023-03-30T18:54:15Z

Build Failed 😱

Build Id: 01e92e44-3ca1-4f84-9c59-a35173b13ad2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-30T20:39:38Z

Build Failed 😱

Build Id: 531063f6-822d-41d7-8883-a21c9a5a9576

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-30T22:50:35Z

Build Failed 😱

Build Id: cf376173-59b9-4d00-a477-7a4e71158fd0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

chiayi · 2023-03-30T22:57:25Z

Build failed due to a different error than prev build:

Step #24 - "submit-e2e-test-cloud-build": generic-1.25: Step #1 - "e2e-feature-gates": FAIL	agones.dev/agones/test/e2e	1800.722s

agones-bot · 2023-04-03T18:54:50Z

Build Failed 😱

Build Id: 9684ff40-2fed-4068-a28f-7bbbcb920136

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

chiayi · 2023-04-03T19:12:11Z

Removed --debug from install

google-oss-prow · 2023-04-03T20:27:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-04-03T21:01:09Z

Build Failed 😱

Build Id: 778e84ad-d139-4e49-8290-271d56aee164

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2023-04-04T00:36:33Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-04-04T01:41:38Z

Build Failed 😱

Build Id: 6126f0bc-347c-41b3-adbf-9136006a4c56

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-04T03:43:00Z

Build Failed 😱

Build Id: 4a14afa0-98aa-4588-9d3e-d077b5929dc8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-04T16:55:13Z

Build Failed 😱

Build Id: 0292aa4b-1c27-45c6-a056-726772cea240

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-04T23:34:39Z

Build Failed 😱

Build Id: eb3493d2-5274-4654-bbf1-8b3ab53e550e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-05T07:40:21Z

Build Succeeded 👏

Build Id: 0d17de03-dac8-4156-a3bb-0890a0339f5e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-fd5c754-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-fd5c754-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-fd5c754-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-fd5c754-amd64
Linux C++ SDK (build): agonessdk-1.31.0-fd5c754-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-fd5c754-amd64.zip

A preview of the website (the last 30 builds are retained):

https://fd5c754-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3051/head:pr_3051 && git checkout pr_3051
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-fd5c754-amd64

agones-bot · 2023-04-05T17:29:30Z

Build Succeeded 👏

Build Id: aeadbc83-eced-40cf-bb03-ec454a39a3d6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-5fcc70b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-5fcc70b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-5fcc70b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-5fcc70b-amd64
Linux C++ SDK (build): agonessdk-1.31.0-5fcc70b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-5fcc70b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5fcc70b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3051/head:pr_3051 && git checkout pr_3051
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-5fcc70b-amd64

* Adds `replicas` and `pdb` settings to `agones.controller` - both are only relevant when `SplitControllerAndExtensions` is enabled. * Derives `--leader-election` and PDB presence from the `replicas` setting: Leader election can be disabled by setting `replicas: 1`.

google-oss-prow bot added the do-not-merge/work-in-progress label Mar 29, 2023

google-oss-prow bot requested review from aLekSer and roberthbailey March 29, 2023 17:17

google-oss-prow bot added the size/M label Mar 29, 2023

chiayi requested review from zmerlynn and removed request for aLekSer March 29, 2023 17:17

zmerlynn requested changes Mar 29, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn Mar 29, 2023

chiayi force-pushed the agoneshabranch branch from c581c3c to d16c79c Compare March 29, 2023 19:00

zmerlynn requested changes Mar 29, 2023

View reviewed changes

chiayi force-pushed the agoneshabranch branch from d16c79c to 8413fa4 Compare March 29, 2023 20:32

chiayi force-pushed the agoneshabranch branch 2 times, most recently from 2b07577 to b0a5e7d Compare March 29, 2023 23:50

zmerlynn approved these changes Mar 30, 2023

View reviewed changes

install/helm/agones/templates/controller.yaml Outdated Show resolved Hide resolved

install/helm/agones/templates/controller.yaml Outdated Show resolved Hide resolved

install/helm/agones/templates/controller.yaml Outdated Show resolved Hide resolved

google-oss-prow bot added the lgtm label Mar 30, 2023

chiayi force-pushed the agoneshabranch branch from b0a5e7d to fb47380 Compare March 30, 2023 00:33

google-oss-prow bot removed the lgtm label Mar 30, 2023

chiayi force-pushed the agoneshabranch branch from fb47380 to 8071fe4 Compare March 30, 2023 17:41

chiayi force-pushed the agoneshabranch branch from 8071fe4 to 4657027 Compare March 30, 2023 22:03

chiayi force-pushed the agoneshabranch branch from 4657027 to ac494f1 Compare March 30, 2023 23:04

chiayi force-pushed the agoneshabranch branch from 761d8fb to 64a7b4c Compare April 3, 2023 17:12

chiayi force-pushed the agoneshabranch branch from 64a7b4c to 804b6df Compare April 3, 2023 19:11

zmerlynn approved these changes Apr 3, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Apr 3, 2023

zmerlynn enabled auto-merge (squash) April 3, 2023 20:28

auto-merge was automatically disabled April 4, 2023 00:36
Head branch was pushed to by a user without write access

chiayi force-pushed the agoneshabranch branch from 804b6df to 8c73199 Compare April 4, 2023 00:36

google-oss-prow bot removed the lgtm label Apr 4, 2023

chiayi force-pushed the agoneshabranch branch from 8c73199 to 1686583 Compare April 4, 2023 15:23

add helm setting for leader election

3511a96

chiayi force-pushed the agoneshabranch branch from 1686583 to 3511a96 Compare April 4, 2023 21:12

Merge branch 'main' into agoneshabranch

fd5c754

Merge branch 'main' into agoneshabranch

d4e1cf4

zmerlynn enabled auto-merge (squash) April 5, 2023 15:34

Merge branch 'main' into agoneshabranch

5fcc70b

zmerlynn merged commit 9eb58c1 into googleforgames:main Apr 5, 2023
2 checks passed

Kalaiselvi84 added the kind/feature New features for Agones label Apr 10, 2023

Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helm setting for leader election #3051

Add helm setting for leader election #3051

chiayi commented Mar 29, 2023

agones-bot commented Mar 29, 2023

zmerlynn Mar 29, 2023

chiayi Mar 29, 2023

zmerlynn Mar 29, 2023

chiayi Mar 29, 2023

agones-bot commented Mar 29, 2023

zmerlynn left a comment

zmerlynn Mar 29, 2023

chiayi Mar 29, 2023

zmerlynn Mar 29, 2023

chiayi Mar 29, 2023

agones-bot commented Mar 29, 2023

zmerlynn left a comment

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

zmerlynn commented Mar 30, 2023

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

chiayi commented Mar 30, 2023

agones-bot commented Apr 3, 2023

chiayi commented Apr 3, 2023

google-oss-prow bot commented Apr 3, 2023

agones-bot commented Apr 3, 2023

google-oss-prow bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 5, 2023

Add helm setting for leader election #3051

Add helm setting for leader election #3051

Conversation

chiayi commented Mar 29, 2023

agones-bot commented Mar 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Mar 29, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Mar 29, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

zmerlynn commented Mar 30, 2023

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

agones-bot commented Mar 30, 2023

chiayi commented Mar 30, 2023

agones-bot commented Apr 3, 2023

chiayi commented Apr 3, 2023

google-oss-prow bot commented Apr 3, 2023

agones-bot commented Apr 3, 2023

google-oss-prow bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 5, 2023