Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action for stale issues #3075

Merged
merged 8 commits into from Apr 7, 2023

Conversation

geetachavan1
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

  1. This PR will automate the process of identifying the stale issues which have been inactive more than 30 days
  2. Wait for another 30 days before marking Obsolete
  3. Wait for another 30 days. if still inactive, it will close the issue.
  4. The issue carries "awaiting maintainer" label will be skipped and will remain open.
  5. At every stage it will add a relevant comment.
  6. To start with, it will run the action on the 1st and 15th of every month and will use the default value of 30 for operations-per-run. This will prevent it from applying stale labels on the all the issues at once.
  7. It is using GitHub Actions CI/CD platform.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

If approved and merged, for the successful run we will need to create following labels

  1. stale
  2. obsolete
  3. close
  4. awaiting maintainer

.github/workflows/close.yaml Show resolved Hide resolved
.github/workflows/close.yaml Show resolved Hide resolved
.github/workflows/close.yaml Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2c7b6319-4bf5-4547-9f62-b3fb85f25f60

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c1bc031-ccd6-4234-a577-63f928b9e349

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3075/head:pr_3075 && git checkout pr_3075
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-caf605e-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geetachavan1, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) April 7, 2023 16:42
@gongmax
Copy link
Collaborator

gongmax commented Apr 7, 2023

Will this workflow close the existing open issues which do not have activity for more than 90 days? Looking at the issue queue, most of them do not have activity for 90 days, my concern is the workflow should not close them silently without us triaging first.

@geetachavan1
Copy link
Contributor Author

Will this workflow close the existing open issues which do not have activity for more than 90 days? Looking at the issue queue, most of them do not have activity for 90 days, my concern is the workflow should not close them silently without us triaging first.

@gongmax The workflow will close only the ones that carry 'obsolete' label and to gain 'obsolete' label first it needs to get the 'stale' label. SO the short answer is NO.. No issues will be closed silently

@gongmax
Copy link
Collaborator

gongmax commented Apr 7, 2023

Will this workflow close the existing open issues which do not have activity for more than 90 days? Looking at the issue queue, most of them do not have activity for 90 days, my concern is the workflow should not close them silently without us triaging first.

@gongmax The workflow will close only the ones that carry 'obsolete' label and to gain 'obsolete' label first it needs to get the 'stale' label. SO the short answer is NO.. No issues will be closed silently

Great!

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 7, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 675c2b5a-ffb8-4bdf-a1ae-145ed3f11ab7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3075/head:pr_3075 && git checkout pr_3075
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-f61272b-amd64

@markmandel markmandel merged commit a92640f into googleforgames:main Apr 7, 2023
2 checks passed
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
* Create stale.yaml

* Create obsolete.yaml

* Create close.yaml

* Update close.yaml

* Update obsolete.yaml

* Update stale.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants