Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quilkin added in third-party-content/examples #3129

Merged
merged 4 commits into from May 3, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

@Kalaiselvi84 Kalaiselvi84 commented Apr 28, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2226

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b424c246-c90c-48dc-99e2-98fb0e53f914

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3129/head:pr_3129 && git checkout pr_3129
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-3369fbd-amd64

@Kalaiselvi84 Kalaiselvi84 requested a review from zmerlynn May 1, 2023 15:48
## Quilkin

* [Quilkin](https://github.com/googleforgames/quilkin) is a non-transparent UDP proxy specifically designed for use with large scale multiplayer dedicated game server deployments, to ensure security, access control, telemetry data, metrics and more.
* [Quilkin with Agones](https://github.com/googleforgames/quilkin/tree/main/examples) is an example of running [Xonotic with Quilkin](https://github.com/googleforgames/quilkin/tree/main/examples/agones-xonotic-sidecar) on an Agones cluster, utilising the sidecar integration pattern and Quilkin xDS Agones provider with a TokenRouter to provide routing and access control to the allocated GameServer instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaking some links, since there are a few options to link to - but otherwise, looks good 👍🏻

Suggested change
* [Quilkin with Agones](https://github.com/googleforgames/quilkin/tree/main/examples) is an example of running [Xonotic with Quilkin](https://github.com/googleforgames/quilkin/tree/main/examples/agones-xonotic-sidecar) on an Agones cluster, utilising the sidecar integration pattern and Quilkin xDS Agones provider with a TokenRouter to provide routing and access control to the allocated GameServer instance.
* [Quilkin with Agones](https://github.com/googleforgames/quilkin/tree/main/examples) is an example of running [Xonotic](https://xonotic.org/) with Quilkin on an Agones cluster, utilising either [the sidecar integration pattern](https://github.com/googleforgames/quilkin/tree/main/examples/agones-xonotic-sidecar) or via the the [Quilkin xDS Agones provider](https://github.com/googleforgames/quilkin/tree/main/examples/agones-xonotic-xds) with a TokenRouter to provide routing and access control to the allocated GameServer instance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified this line

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 78906d54-db7b-4f4c-a9a2-8f09f9d1fc46

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8cf7df24-19da-45e2-83f3-179d3fa33a7d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ad1f319-3712-4197-9321-ae8f32e61db7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3129/head:pr_3129 && git checkout pr_3129
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-8135b49-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 440ce31 into googleforgames:main May 3, 2023
2 checks passed
@Kalaiselvi84 Kalaiselvi84 added the kind/documentation Documentation for Agones label May 18, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the issues/2226 branch March 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved good first issue These are great first issues. If you are looking for a place to start, start here! kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
3 participants