Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for one issue with TestFleetRecreateGameServers test #3163

Merged
merged 1 commit into from May 19, 2023

Conversation

chiayi
Copy link
Collaborator

@chiayi chiayi commented May 18, 2023

Add fix for one issue with TestFleetRecreateGameServers test

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
The test TestFleetRecreateGameServers fails due to an issue with the number of gameservers it receives, instead of having 10, it gets 11 gameservers. And one of the gameservers would be in Shutdown state.

Which issue(s) this PR fixes:
TestFleetRecreateGameServers flakiness

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: de35bfaa-c503-4385-856b-c42ea81e4d7a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3163/head:pr_3163 && git checkout pr_3163
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-b44df3f-amd64

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch for this corner case!

@google-oss-prow google-oss-prow bot added lgtm and removed lgtm labels May 18, 2023
@chiayi chiayi marked this pull request as ready for review May 18, 2023 23:00
@google-oss-prow google-oss-prow bot requested a review from markmandel May 18, 2023 23:00
test/e2e/fleet_test.go Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label May 18, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) May 18, 2023 23:42
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 98f7664c-9438-4304-9c81-da95a6d70e7c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b0b97bdc-5a97-4607-b520-9e459aca9a70

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3163/head:pr_3163 && git checkout pr_3163
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-752e093-amd64

@zmerlynn zmerlynn merged commit ebc40d3 into googleforgames:main May 19, 2023
1 of 2 checks passed
chiayi added a commit to chiayi/agones that referenced this pull request May 19, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/bug These are bugs. label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants