Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about which namespace is used for game serves deployed from fleets #3288

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

mikeseese
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

This PR provides additional context about where GameServer resources are deployed from when instantiated by Fleet's. Specifically, this addition attempts to remove confusion for those thinking that the helm chart value gameservers.namespaces changes where game servers are deployed by explicitly stating they deploy where the fleet is deployed. In the event that someone deploys a Fleet on a namespace that isn't included in the helm chart value gameservers.namespaces, they will end up receiving the error:

error looking up service account agones-system/agones-sdk: serviceaccount "agones-sdk" not found

similar to #146 and #1370 (references included for others in the same situation as me finding those posts via Google).

This PR attempts to prevent users from getting into this scenario in the first place.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:
This PR was the result of this Slack thread

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Jul 27, 2023
@aimuz
Copy link
Collaborator

aimuz commented Jul 27, 2023

/lgtm

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ff625070-9fdd-472c-924b-0e90cb4ba4ed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3288/head:pr_3288 && git checkout pr_3288
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-20fe945-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, was just dealing with some gnarly bugs.

Really good addition! Thanks for the contribution!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, mikeseese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 2, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel enabled auto-merge (squash) August 2, 2023 00:36
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 75c039fa-b88c-4db5-8a8e-0bb13949737d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f311a70c-87c0-4594-91bf-71bc9c0c74fb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3288/head:pr_3288 && git checkout pr_3288
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-77046b4-amd64

@markmandel markmandel merged commit 1f94e8f into googleforgames:main Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants