Cloudbuild script for autoscaler-webhook #3298

Kalaiselvi84 · 2023-07-31T23:21:41Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3281

Special notes for your reviewer:

Kalaiselvi84 · 2023-07-31T23:23:07Z

build succeeded for autoscaler-webhook in my project.

autoscaler-webhook-logs

kubectl describe fleetautoscaler webhook-fleet-autoscaler

Kalaiselvi84 · 2023-07-31T23:29:38Z

If everything looks good in this PR, I'll start working on the remaining images🙂

agones-bot · 2023-08-01T00:12:04Z

Build Failed 😱

Build Id: 2fbd2a8c-7f72-4149-b50f-381a716f2d1e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-01T01:40:38Z

Build Succeeded 👏

Build Id: abdcc481-d110-4b73-a857-ea667215b4d2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ceba863-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3298/head:pr_3298 && git checkout pr_3298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-ceba863-amd64

agones-bot · 2023-08-01T20:11:13Z

Build Succeeded 👏

Build Id: 4b6243a3-cb25-4995-b80e-8fdec0912760

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://15d3aa0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3298/head:pr_3298 && git checkout pr_3298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-15d3aa0-amd64

agones-bot · 2023-08-02T05:41:21Z

Build Succeeded 👏

Build Id: 0f8b3b6b-fdcc-4733-baf6-f70c9917d938

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ec2a6ed-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3298/head:pr_3298 && git checkout pr_3298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-ec2a6ed-amd64

Kalaiselvi84 · 2023-08-03T20:48:54Z

@markmandel, Would you mind taking a look at this PR? I've made changes to the Dockerfile, go.mod, and go.sum as well. It's worth noting that these files remain unmodified in other PRs for example/images.

Kalaiselvi84 · 2023-08-03T20:56:44Z

examples/autoscaler-webhook/Makefile

@@ -39,16 +45,20 @@ root_path = $(realpath $(project_path)/../..)

 # Build a docker image for the server, and tag it
 build:
-	cd $(root_path) && docker build -f $(project_path)/Dockerfile --tag=$(autoscaler_webhook_tag) .
+	cd $(project_path) && docker build -f $(project_path)/Dockerfile --tag=$(autoscaler_webhook_tag) .


Can you please share if there is a better alternative to changing the $(root_path)?

I attempted to use $(root_path) as a substitution in the build script, but it didn't work as expected.

Not entirely sure why the change in name here (although project vs root I don't really mind).

That being said, I think you could revert this lines change, and with my suggestions below this will work.

yes, root_path works!

markmandel · 2023-08-03T20:57:49Z

examples/autoscaler-webhook/go.mod

@@ -46,5 +46,3 @@ require (
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
 	sigs.k8s.io/yaml v1.3.0 // indirect
 )
-
-replace agones.dev/agones => ../../


So for this image, this line does need to stay.

included this line

markmandel · 2023-08-03T20:59:56Z

examples/autoscaler-webhook/Makefile

+
+# build and push the autoscaler-webhook image with specified tag
+cloud-build:
+	gcloud builds submit --config=cloudbuild.yaml


I think what we'll need to do here instead (since the replace exists in the go.mod), will be something like:

Suggested change

gcloud builds submit --config=cloudbuild.yaml

cd $(project_path) && gcloud builds submit --config=./examples/autoscaler-webhook/cloudbuild.yaml

Since we'll need to push up the entire Agones project with this one (I expect the same with simple-game-server).

root_path is required since we are passing ./examples/autoscaler-webhook/cloudbuild.yaml

markmandel · 2023-08-03T21:00:26Z

examples/autoscaler-webhook/cloudbuild.yaml

+  # build and push allocation-endpoint image to GCR
+  - name: "make-docker"
+    id: push
+    dir: "."


Suggested change

dir: "."

dir: "/workspace/examples/autoscaler-webhook/"

Pretty sure that's right, since we have the whole Agones project in this one.

This path makes everything works as expected. Thanks!

agones-bot · 2023-08-03T22:11:21Z

Build Failed 😱

Build Id: ed2209ad-09ce-499e-8cb7-3998b5a07779

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-04T18:21:20Z

Build Succeeded 👏

Build Id: c72e6afc-5c67-4fc0-a77f-14d02bce5bd5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://07ed16d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3298/head:pr_3298 && git checkout pr_3298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-07ed16d-amd64

markmandel · 2023-08-04T19:00:03Z

Just triple checking before approving - all working as expected now?

Kalaiselvi84 · 2023-08-04T20:34:49Z

Just triple checking before approving - all working as expected now?

The build has succeeded for the cloud-build script, and the autoscaler-image has been updated in my project. You can view the details here. Could you please confirm if anything I need to check?

markmandel

Awesome.

google-oss-prow · 2023-08-04T20:40:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kalaiselvi84 added 2 commits July 31, 2023 23:17

cloudbuild script for autoscaler-webhook

def080f

update project

11d7b5f

Kalaiselvi84 requested a review from markmandel July 31, 2023 23:21

google-oss-prow bot added the size/M label Jul 31, 2023

github-actions bot added the kind/feature New features for Agones label Jul 31, 2023

google-oss-prow bot requested review from cyriltovena and EricFortin July 31, 2023 23:22

Merge branch 'main' into bs-cpp-simple

ceba863

Kalaiselvi84 marked this pull request as draft August 1, 2023 17:33

google-oss-prow bot added the do-not-merge/work-in-progress label Aug 1, 2023

Kalaiselvi84 added 2 commits August 1, 2023 19:08

changed path in Dockerfile

f13027d

Merge branch 'main' into bs-cpp-simple

15d3aa0

Kalaiselvi84 marked this pull request as ready for review August 1, 2023 19:15

google-oss-prow bot removed the do-not-merge/work-in-progress label Aug 1, 2023

Kalaiselvi84 added 2 commits August 2, 2023 03:30

Merge branch 'main' into bs-cpp-simple

3579ba0

small tweak

ec2a6ed

Kalaiselvi84 commented Aug 3, 2023

View reviewed changes

markmandel reviewed Aug 3, 2023

View reviewed changes

revert Dockerfile, go.mod, go.sum and fixed path

6a5ddcc

Merge branch 'main' into bs-cpp-simple

07ed16d

markmandel approved these changes Aug 4, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Aug 4, 2023

google-oss-prow bot added the lgtm label Aug 4, 2023

markmandel merged commit 33a02dd into googleforgames:main Aug 4, 2023
3 checks passed

google-oss-prow bot added the approved label Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloudbuild script for autoscaler-webhook #3298

Cloudbuild script for autoscaler-webhook #3298

Kalaiselvi84 commented Jul 31, 2023

Kalaiselvi84 commented Jul 31, 2023 •

edited

Kalaiselvi84 commented Jul 31, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 2, 2023

Kalaiselvi84 commented Aug 3, 2023

Kalaiselvi84 Aug 3, 2023 •

edited

markmandel Aug 3, 2023

Kalaiselvi84 Aug 3, 2023

markmandel Aug 3, 2023

Kalaiselvi84 Aug 3, 2023

markmandel Aug 3, 2023

Kalaiselvi84 Aug 3, 2023

markmandel Aug 3, 2023

Kalaiselvi84 Aug 3, 2023

agones-bot commented Aug 3, 2023

agones-bot commented Aug 4, 2023

markmandel commented Aug 4, 2023

Kalaiselvi84 commented Aug 4, 2023

markmandel left a comment

google-oss-prow bot commented Aug 4, 2023

	gcloud builds submit --config=cloudbuild.yaml
	cd $(project_path) && gcloud builds submit --config=./examples/autoscaler-webhook/cloudbuild.yaml

Cloudbuild script for autoscaler-webhook #3298

Cloudbuild script for autoscaler-webhook #3298

Conversation

Kalaiselvi84 commented Jul 31, 2023

Kalaiselvi84 commented Jul 31, 2023 • edited

Kalaiselvi84 commented Jul 31, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 1, 2023

agones-bot commented Aug 2, 2023

Kalaiselvi84 commented Aug 3, 2023

Kalaiselvi84 Aug 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Aug 3, 2023

agones-bot commented Aug 4, 2023

markmandel commented Aug 4, 2023

Kalaiselvi84 commented Aug 4, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 4, 2023

Kalaiselvi84 commented Jul 31, 2023 •

edited

Kalaiselvi84 Aug 3, 2023 •

edited