Cloud build script for simple-game-server #3314

Kalaiselvi84 · 2023-08-07T18:21:00Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3281

Special notes for your reviewer:

Kalaiselvi84 · 2023-08-07T18:41:07Z

@markmandel, I tried updating the Dockerfile.windows and it is not working as expected. could you please review this PR and provide your feedback?

agones-bot · 2023-08-07T19:18:03Z

Build Succeeded 👏

Build Id: f023c831-5906-4e19-b020-6db8de84b554

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d1538ba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-d1538ba-amd64

examples/simple-game-server/Dockerfile.windows

agones-bot · 2023-08-09T03:54:44Z

Build Succeeded 👏

Build Id: d0950c85-ef38-4298-9c75-8c8949bfb697

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://591cadd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-591cadd-amd64

markmandel · 2023-08-10T17:05:07Z

examples/simple-game-server/Dockerfile.windows

+FROM golang:1.20.4-windowsservercore as builder
+SHELL ["powershell", "-command"]


Suggested change

FROM golang:1.20.4-windowsservercore as builder

SHELL ["powershell", "-command"]

FROM --platform=linux/amd64 golang:1.20.4 as base

Is what it should be, since we can't run windows containers on Linux.

I've updated the platform to the linux/amd64 architecture. According to the log, it's recommended to include the pkg/sdk, pkg/util/signals, and sdks/go modules. However, I've noticed that the files remain unchanged when I test this locally. Could you please review this build?

agones-bot · 2023-08-11T02:47:57Z

Build Succeeded 👏

Build Id: a93dff54-1209-40bc-919a-da4f7b63568a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ae92696-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-ae92696-amd64

examples/simple-game-server/Dockerfile.windows

markmandel · 2023-08-14T18:31:42Z

examples/simple-game-server/Dockerfile.windows

+WORKDIR /gopath/src
+COPY . /gopath/src/


Let's make this the same as

agones/examples/simple-game-server/Dockerfile

Lines 16 to 21 in ae92696

FROM golang:1.20.4 as builder

WORKDIR /go/src

COPY . agones.dev/agones

WORKDIR /go/src/agones.dev/agones/examples/simple-game-server

RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o server .

for consistency.

Suggested change

WORKDIR /gopath/src

COPY . /gopath/src/

WORKDIR /go/src

COPY . /go/src/

The Linux build is functioning properly, but the Windows build has an issue: there are no files in /go/src/agones.dev/agones/examples/simple-game-server. This is due to the COPY . agones.dev/agones command, which only copies files from the simple-game-server. Log details can be found here. Linux build is failing if we adjust the work directory path in cloudbuild.yaml file.

Step #2 - "push": #9 [base 2/8] WORKDIR /go/src Step #2 - "push": #9 DONE 0.7s Step #2 - "push": Step #2 - "push": #10 [base 3/8] COPY . agones.dev/agones Step #2 - "push": #10 DONE 0.1s Step #2 - "push": Step #2 - "push": #11 [base 4/8] RUN ls -ltr Step #2 - "push": #0 0.150 total 4 Step #2 - "push": #0 0.150 drwxr-xr-x 3 root root 4096 Aug 14 19:19 agones.dev Step #2 - "push": #11 DONE 0.2s Step #2 - "push": Step #2 - "push": Step #2 - "push": #12 [base 5/8] RUN ls -ltr /go/src/agones.dev/agones Step #2 - "push": #0 0.135 total 88 Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1129 Aug 4 01:08 gameserverallocation.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1080 Aug 4 01:08 gameserver.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1183 Aug 4 01:08 gameserver-windows.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1131 Aug 4 01:08 gameserver-passthrough.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 945 Aug 4 01:08 fleetautoscaler.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1136 Aug 4 01:08 fleet.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1406 Aug 4 01:08 fleet-tcp.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1346 Aug 4 01:08 fleet-distributed.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1200 Aug 4 01:08 dev-gameserver.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 3682 Aug 4 01:08 README.md Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1017 Aug 4 01:08 Dockerfile Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 2507 Aug 7 17:13 go.sum Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 578 Aug 7 17:13 go.mod Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 16836 Aug 10 13:15 main.go Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1300 Aug 12 19:22 cloudbuild.yaml Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 5481 Aug 12 19:22 Makefile Step #2 - "push": #0 0.135 -rw-r--r-- 1 root root 1661 Aug 14 19:14 Dockerfile.windows Step #2 - "push": #12 DONE 0.2s Step #2 - "push": Step #2 - "push": #13 [base 6/8] WORKDIR /go/src/agones.dev/agones/examples/simple-game-server Step #2 - "push": #13 DONE 0.0s Step #2 - "push": Step #2 - "push": #14 [base 7/8] RUN ls -ltr Step #2 - "push": #14 0.153 total 0 Step #2 - "push": #14 DONE 0.2s

🤔 so the line that fails is:

Step #2 - "push": #15 0.339 agones.dev/agones@v1.33.0 (replaced by ../../): reading /go/src/go.mod: open /go/src/go.mod: no such file or directory

I think I see the issue, it's in the makefile.

You can see how the linux image is built to run from the $(root_path):

agones/examples/simple-game-server/Makefile

Lines 125 to 128 in 2a6091f

build-linux-image-amd64:

cd $(root_path) && docker build -f $(project_path)Dockerfile --tag=$(REPOSITORY)$(server_tag_linux_amd64) .

build-linux-image-arm64:

cd $(root_path) && docker buildx build --platform linux/arm64 -f $(project_path)Dockerfile $(DOCKER_BUILD_ARGS) --tag=$(server_tag_linux_arm64) .

But if we look at the Windows target, we see:

agones/examples/simple-game-server/Makefile

Lines 111 to 114 in 2a6091f

build-windows-image-%: ensure-windows-buildx

cd $(root_path) && DOCKER_CLI_EXPERIMENTAL=enabled \

docker buildx build --platform windows/amd64 --builder $(BUILDX_WINDOWS_BUILDER) -f $(project_path)Dockerfile.windows \

--tag=$(REPOSITORY)$(server_tag)-windows_amd64-$* --build-arg WINDOWS_VERSION=$* examples/simple-game-server/ $(WINDOWS_DOCKER_PUSH_ARGS)

Where previously there should be . there is examples/simple-game-server/. I think if you fixup that, then that will resolve the issue (or at least get you closer).

agones-bot · 2023-08-14T19:56:02Z

Build Succeeded 👏

Build Id: b95b5c13-0d4c-46d2-9bbf-a67a737ea82e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2a6091f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-2a6091f-amd64

markmandel · 2023-08-15T18:28:59Z

examples/simple-game-server/Dockerfile.windows

 ARG WINDOWS_VERSION=ltsc2019

+# create a Base Image from Golang, This sets up a build stage named "base" using a specific version of the Golang image.
+# The platform is specified as Linux on AMD64 architecture
+FROM --platform=linux/amd64 golang:1.20.4 as base


Nit: "builder" is more common.

Suggested change

FROM --platform=linux/amd64 golang:1.20.4 as base

FROM --platform=linux/amd64 golang:1.20.4 as builder

updated with builder

markmandel · 2023-08-15T18:35:36Z

examples/simple-game-server/Dockerfile.windows

+WORKDIR /gopath/src
+COPY . /gopath/src/


🤔 so the line that fails is:

Step #2 - "push": #15 0.339 agones.dev/agones@v1.33.0 (replaced by ../../): reading /go/src/go.mod: open /go/src/go.mod: no such file or directory

I think I see the issue, it's in the makefile.

You can see how the linux image is built to run from the $(root_path):

agones/examples/simple-game-server/Makefile

Lines 125 to 128 in 2a6091f

build-linux-image-amd64:

cd $(root_path) && docker build -f $(project_path)Dockerfile --tag=$(REPOSITORY)$(server_tag_linux_amd64) .

build-linux-image-arm64:

cd $(root_path) && docker buildx build --platform linux/arm64 -f $(project_path)Dockerfile $(DOCKER_BUILD_ARGS) --tag=$(server_tag_linux_arm64) .

But if we look at the Windows target, we see:

agones/examples/simple-game-server/Makefile

Lines 111 to 114 in 2a6091f

build-windows-image-%: ensure-windows-buildx

cd $(root_path) && DOCKER_CLI_EXPERIMENTAL=enabled \

docker buildx build --platform windows/amd64 --builder $(BUILDX_WINDOWS_BUILDER) -f $(project_path)Dockerfile.windows \

--tag=$(REPOSITORY)$(server_tag)-windows_amd64-$* --build-arg WINDOWS_VERSION=$* examples/simple-game-server/ $(WINDOWS_DOCKER_PUSH_ARGS)

Where previously there should be . there is examples/simple-game-server/. I think if you fixup that, then that will resolve the issue (or at least get you closer).

Kalaiselvi84 · 2023-08-15T21:23:08Z

Where previously there should be . there is examples/simple-game-server/. I think if you fixup that, then that will resolve the issue (or at least get you closer).

This change fixed the problem. Successful build in my project

agones-bot · 2023-08-15T22:24:13Z

Build Succeeded 👏

Build Id: e1c45d46-aa95-49b0-b22a-75a4737aed63

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://40cd326-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-40cd326-amd64

agones-bot · 2023-08-16T19:00:46Z

Build Succeeded 👏

Build Id: 2c294eb8-248c-44f2-bbca-a0d545c96281

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2a48c46-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3314/head:pr_3314 && git checkout pr_3314
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-2a48c46-amd64

Kalaiselvi84 · 2023-08-16T22:06:44Z

@markmandel, I am double-checking to confirm that the build for this script has succeeded in my project.

markmandel

Fantastic!

google-oss-prow · 2023-08-17T18:09:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kalaiselvi84 added 2 commits August 7, 2023 18:14

Cloud build script for simple-game-server

5795629

Condition to fetch repository

d1538ba

Kalaiselvi84 requested a review from markmandel August 7, 2023 18:21

google-oss-prow bot added do-not-merge/work-in-progress size/M labels Aug 7, 2023

github-actions bot added the kind/feature New features for Agones label Aug 7, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey August 7, 2023 18:21

markmandel reviewed Aug 8, 2023

View reviewed changes

examples/simple-game-server/Dockerfile.windows Outdated Show resolved Hide resolved

Modified after comparing related files

591cadd

markmandel reviewed Aug 10, 2023

View reviewed changes

Alter Dockerfile.windows

ae92696

markmandel reviewed Aug 14, 2023

View reviewed changes

Kalaiselvi84 added 2 commits August 14, 2023 18:46

suggested changes

43456ff

updated path

2a6091f

markmandel reviewed Aug 15, 2023

View reviewed changes

update path in build-windows-image

40cd326

Merge branch 'main' into bs-simple-gs

2a48c46

Kalaiselvi84 marked this pull request as ready for review August 16, 2023 17:53

google-oss-prow bot removed the do-not-merge/work-in-progress label Aug 16, 2023

google-oss-prow bot requested a review from aLekSer August 16, 2023 17:53

markmandel approved these changes Aug 17, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Aug 17, 2023

google-oss-prow bot added the lgtm label Aug 17, 2023

google-oss-prow bot added the approved label Aug 17, 2023

markmandel merged commit e24353a into googleforgames:main Aug 17, 2023
3 checks passed

Kalaiselvi84 deleted the bs-simple-gs branch March 15, 2024 01:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloud build script for simple-game-server #3314

Cloud build script for simple-game-server #3314

Kalaiselvi84 commented Aug 7, 2023 •

edited

Kalaiselvi84 commented Aug 7, 2023

agones-bot commented Aug 7, 2023

agones-bot commented Aug 9, 2023

markmandel Aug 10, 2023

Kalaiselvi84 Aug 11, 2023

agones-bot commented Aug 11, 2023

markmandel Aug 14, 2023

Kalaiselvi84 Aug 14, 2023 •

edited

markmandel Aug 15, 2023 •

edited

agones-bot commented Aug 14, 2023

markmandel Aug 15, 2023

Kalaiselvi84 Aug 15, 2023

markmandel Aug 15, 2023 •

edited

Kalaiselvi84 commented Aug 15, 2023

agones-bot commented Aug 15, 2023

agones-bot commented Aug 16, 2023

Kalaiselvi84 commented Aug 16, 2023

markmandel left a comment

google-oss-prow bot commented Aug 17, 2023

		FROM golang:1.20.4-windowsservercore as builder
		SHELL ["powershell", "-command"]

	FROM golang:1.20.4-windowsservercore as builder
	SHELL ["powershell", "-command"]
	FROM --platform=linux/amd64 golang:1.20.4 as base

	FROM golang:1.20.4 as builder
	WORKDIR /go/src
	COPY . agones.dev/agones

	WORKDIR /go/src/agones.dev/agones/examples/simple-game-server
	RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o server .

	build-linux-image-amd64:
	cd $(root_path) && docker build -f $(project_path)Dockerfile --tag=$(REPOSITORY)$(server_tag_linux_amd64) .
	build-linux-image-arm64:
	cd $(root_path) && docker buildx build --platform linux/arm64 -f $(project_path)Dockerfile $(DOCKER_BUILD_ARGS) --tag=$(server_tag_linux_arm64) .

	build-windows-image-%: ensure-windows-buildx
	cd $(root_path) && DOCKER_CLI_EXPERIMENTAL=enabled \
	docker buildx build --platform windows/amd64 --builder $(BUILDX_WINDOWS_BUILDER) -f $(project_path)Dockerfile.windows \
	--tag=$(REPOSITORY)$(server_tag)-windows_amd64-$* --build-arg WINDOWS_VERSION=$* examples/simple-game-server/ $(WINDOWS_DOCKER_PUSH_ARGS)

Cloud build script for simple-game-server #3314

Cloud build script for simple-game-server #3314

Conversation

Kalaiselvi84 commented Aug 7, 2023 • edited

Kalaiselvi84 commented Aug 7, 2023

agones-bot commented Aug 7, 2023

agones-bot commented Aug 9, 2023

markmandel Aug 10, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 11, 2023

Choose a reason for hiding this comment

agones-bot commented Aug 11, 2023

markmandel Aug 14, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 14, 2023 • edited

Choose a reason for hiding this comment

markmandel Aug 15, 2023 • edited

Choose a reason for hiding this comment

agones-bot commented Aug 14, 2023

markmandel Aug 15, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Aug 15, 2023

Choose a reason for hiding this comment

markmandel Aug 15, 2023 • edited

Choose a reason for hiding this comment

Kalaiselvi84 commented Aug 15, 2023

agones-bot commented Aug 15, 2023

agones-bot commented Aug 16, 2023

Kalaiselvi84 commented Aug 16, 2023

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 17, 2023

Kalaiselvi84 commented Aug 7, 2023 •

edited

Kalaiselvi84 Aug 14, 2023 •

edited

markmandel Aug 15, 2023 •

edited

markmandel Aug 15, 2023 •

edited