Bump GitHub workflow actions to latest versions

[deining]

What this PR does / Why we need it:

This PR bumps GitHub workflow actions to their latest versions. This avoids warning messages as seen here.

[agones-bot]

Build Succeeded 👏

Build Id: e1775258-3325-4938-9525-9c0b2cef5854

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.35.0-dev-71de4b9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.35.0-dev-71de4b9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.35.0-dev-71de4b9-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.35.0-dev-71de4b9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.35.0-dev-71de4b9-amd64
• Linux C++ SDK (build): agonessdk-1.35.0-dev-71de4b9-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.35.0-dev-71de4b9-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://71de4b9-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3355/head:pr_3355 && git checkout pr_3355
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-71de4b9-amd64

[aimuz]

Looks good.

/lgtm

[markmandel]

@Kalaiselvi84 you've worked the most on github actions, just wanted to triple check with you before approving. You see any issues?

[Kalaiselvi84]

I will test in my fork and update here shortly..

[Kalaiselvi84]

@markmandel, I tested the Label-PR script with the elevated version and it's not working as expected. Here's the link

[markmandel]

@markmandel, I tested the Label-PR script with the elevated version and it's not working as expected. Here's the link

Sorry, can you point out the issue, I'm having a hard time seeing it.

[Kalaiselvi84]

I received the following error:
Error retrieving files: TypeError: Cannot read properties of undefined (reading 'addLabels')

Error log: https://gist.github.com/Kalaiselvi84/bdc04f75d76008fc17ded1422cdd88f1

If I understand correctly, I've tried using label-pr with v6 and found that some of the attributes from the previous versions aren't supported by this new version.

May I know how are we testing the other Action workflows(close, stale, and obsolete)?

[markmandel]

Interesting, is this because there was no label specified in the description?

(Although I look at the logs, it seems like there is?)

If we can't upgrade, then we can't upgrade -- warnings are not the end of the world. or flip side @deining if you are keen to update the script so it will work, that would be good too.

May I know how are we testing the other Action workflows(close, stale, and obsolete)?

Honestly, probably just making the change and seeing what happens (which is less than ideal, so we may not want to change that one).

[Kalaiselvi84]

(Although I look at the logs, it seems like there is?)

Yes, I chose /kind cleanup and didn't add a new line. However, it doesn't matter.

https://screenshot.googleplex.com/5sRr2AwNauSM2w7

which is less than ideal, so we may not want to change that one

I agree with your suggestion👍🏻

[markmandel]

Either way if gihub.issues.addLabels doesn't exist, it's a moot point. It's not going to work anyway.

[aimuz]

https://github.com/actions/github-script#apply-a-label-to-an-issue

It looks like the github-script has been tweaked a bit and should be reformatted as follows

github.rest.issues.addLabels

on:
  issues:
    types: [opened]

jobs:
  apply-label:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/github-script@v6
        with:
          script: |
            github.rest.issues.addLabels({
              issue_number: context.issue.number,
              owner: context.repo.owner,
              repo: context.repo.repo,
              labels: ['Triage']
            })

[Kalaiselvi84]

@aimuz, Thanks for sharing github.rest.issues.addLabels. It works!
Log - https://gist.github.com/Kalaiselvi84/e65b7e9f13986565a1d6bff1b2878362

[markmandel]

@deining are you able to make those updates to this PR (and also resolve the conflicts please)?

[agones-bot]

Build Failed 😱

Build Id: c2cf2482-c018-498a-ba36-3c82175ce50a

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[Kalaiselvi84]

@deining, would you mind appending a line to the end of the obsolete, stale, and close.yaml files to address the linting issue, please?

[deining]

@deining, would you mind appending a line to the end of the obsolete, stale, and close.yaml files to address the linting issue, please?

Done.

I also rebase my branch, it is not out-of-date any more.

[agones-bot]

Build Failed 😱

Build Id: 41bf4813-19c4-4824-bcc8-33d6cc490bec

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 08a3d078-275e-4fbd-b7a6-46a4e13c1bbc

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: e68928c8-fd48-469e-9d87-6bd717a411d7

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.35.0-dev-2f0b020-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.35.0-dev-2f0b020-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.35.0-dev-2f0b020-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.35.0-dev-2f0b020-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.35.0-dev-2f0b020-amd64
• Linux C++ SDK (build): agonessdk-1.35.0-dev-2f0b020-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.35.0-dev-2f0b020-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://2f0b020-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3355/head:pr_3355 && git checkout pr_3355
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-2f0b020-amd64

[aimuz]

/lgtm

[markmandel]

@Kalaiselvi84 you have the most experience with these tools - any objection to approving and merging?

[Kalaiselvi84]

LGTM!

[markmandel]

HERE WE GO 😃

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, deining, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment