Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Allocation Overflow Documentation #3368

Merged
merged 7 commits into from Sep 12, 2023
Merged

Update: Allocation Overflow Documentation #3368

merged 7 commits into from Sep 12, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

@Kalaiselvi84 Kalaiselvi84 commented Sep 8, 2023 •
edited by markmandel

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Fix documentation bugs in allocationOverflow documentation.

Which issue(s) this PR fixes:

Closes #3361

Special notes for your reviewer:

@github-actions github-actions bot added the kind/documentation Documentation for Agones label Sep 8, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 59cd6021-0c32-4adb-bc51-7c06bb276233

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-3fd66d3-amd64

@markmandel
Copy link
Member

Looks good!

Can we also add a line to https://agones.dev/site/docs/guides/fleet-updates/#notifying-gameservers-on-fleet-updatedownscale specifying:

The labels and/or annotations are applied to GameServers in a Fleet in the order designated by their configured Fleet scheduling.

I think the best place for this is here:

agones/site/content/en/docs/Guides/fleet-updates.md

Line 150 in 9deb15f

I think that should cover things.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Sep 12, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b29ee068-ffe5-4412-9069-3180c53ee936

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-c7c483b-amd64

markmandel
markmandel reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍🏻

site/content/en/docs/Guides/fleet-updates.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d93bb547-f674-4920-afbe-2cb1bd4aacd0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-cae172f-amd64

markmandel
markmandel reviewed Sep 12, 2023
View reviewed changes
site/content/en/docs/Guides/fleet-updates.md Outdated
@@ -147,6 +147,8 @@ This provides two useful capabilities:
2. This can also be used to proactively update `GameServer` labels, to effect change in allocation strategy - such as
preferring the newer `GameServers` when allocating, but falling back to the older version if there aren't enough
of the new ones yet spun up.

The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}})
The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}).

Small final nit!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5f56c46c-0d6d-4d4b-8855-be5a4feb70da

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-927fa6c-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Sep 12, 2023
@markmandel markmandel enabled auto-merge (squash) September 12, 2023 22:32
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 12, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 78344229-721c-4acb-9f6f-9384a3ffe8d5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3368/head:pr_3368 && git checkout pr_3368
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-ebb5de3-amd64

@markmandel markmandel merged commit 963fb15 into googleforgames:main Sep 12, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the overflow branch March 15, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved kind/documentation Documentation for Agones size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allocationOverflow documentation issue
3 participants
@Kalaiselvi84 @agones-bot @markmandel