Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TestGameServerResourceValidation flake #3373

Merged

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 12, 2023

What type of PR is this?

/kind bug

What this PR does / Why we need it:

Fixes TestGameServerResourceValidation flaky test by sorting the returned errors for a deterministic result.

Which issue(s) this PR fixes:

Closes #3362

Special notes for your reviewer:

@github-actions github-actions bot added the kind/bug These are bugs. label Sep 12, 2023
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emphatic approval!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 73a25f7a-8572-4bda-bcde-044ea09a1093

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3373/head:pr_3373 && git checkout pr_3373
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-f0310c7-amd64

@zmerlynn zmerlynn merged commit 0e62bc5 into googleforgames:main Sep 12, 2023
3 checks passed
@igooch igooch deleted the FlakyTestGameServerResourceValidation branch September 12, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky: TestGameServerResourceValidation
5 participants