Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GameServer e2e tests for Counters #3381

Merged
merged 3 commits into from Sep 15, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 14, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds GameServer e2e tests for Counters

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Sep 14, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5660dd3b-b453-40cc-94ce-cbfcb3a799b9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3381/head:pr_3381 && git checkout pr_3381
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-9937cc8-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on error checking, but otherwise, LGTM!

test/e2e/gameserver_test.go Outdated Show resolved Hide resolved
test/e2e/gameserver_test.go Outdated Show resolved Hide resolved
test/e2e/gameserver_test.go Outdated Show resolved Hide resolved
test/e2e/gameserver_test.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fa1a2402-b084-431f-a015-bb2d0d35b04f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3381/head:pr_3381 && git checkout pr_3381
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-576101f-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0937ea26-f434-4105-bf8f-d3a36e34894f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3381/head:pr_3381 && git checkout pr_3381
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-0e003d7-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy as!

@google-oss-prow google-oss-prow bot added the lgtm label Sep 15, 2023
@markmandel markmandel merged commit 8ed3deb into googleforgames:main Sep 15, 2023
3 checks passed
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants