Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more items to .gcloudignore #3383

Merged
merged 1 commit into from Sep 18, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Was doing some Cloud Build testing with simple-game-server, and with these changes dropped my upload from several terabytes to ~350MB.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Sep 15, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 15, 2023
@markmandel
Copy link
Member Author

@Kalaiselvi84 @igooch This should make things easier for updates to any of the examples 😃

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Sep 15, 2023
@igooch
Copy link
Collaborator

igooch commented Sep 15, 2023

The #!include:.gitignore ignores all files that are included in the .gitignore file, we might want to keep that?

@markmandel
Copy link
Member Author

The #!include:.gitignore ignores all files that are included in the .gitignore file, we might want to keep that?

Huh that's weird, I didn't even realise I removed that. I didn't think that actually did anything! Lemme add it back in.

Was doing some Cloud Build testing with simple-game-server, and with
these changes dropped my upload from several terabytes to ~350MB.
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9eb3f31d-5a0b-40e1-851d-91de5d3bbf32

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3ab6dcce-a9a1-4f3f-a423-0144966d01f7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3383/head:pr_3383 && git checkout pr_3383
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-883690e-amd64

@markmandel markmandel merged commit 73bf077 into googleforgames:main Sep 18, 2023
3 checks passed
@markmandel markmandel deleted the cleanup/gcloudignore branch September 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants