Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the gs state correctly in error message #3385

Merged
merged 1 commit into from Sep 19, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Sep 18, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
When Update fails, the returned gs is nil. Change to get the GameServer state properly from gsCopy.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/bug These are bugs. label Sep 18, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8da97454-db5f-44b1-b9ab-cbc57cb0ef45

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

Possible new flake:

Trace[539986959]: [29.993551965s] [29.993551965s] END
panic: test timed out after 10m0s
running tests:
	TestControllerSyncGameServer (9m59s)
	TestControllerSyncGameServer/Creating_a_new_GameServer (9m59s)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2bd92212-cfce-4f1f-b678-192486f8c96f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3385/head:pr_3385 && git checkout pr_3385
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-2c7c24f-amd64

@gongmax gongmax merged commit ecddebe into googleforgames:main Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants