Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nodejs Apt Repository to latest #3435

Merged
merged 2 commits into from Oct 18, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3430

Special notes for your reviewer:

@Kalaiselvi84
Copy link
Contributor Author

A new image tag has been pushed to my project:
https://screenshot.googleplex.com/8Z3bfUUAxKikGH8

Build log - https://gist.github.com/Kalaiselvi84/5996617343f683ba82d1e06a0425e17a

Please confirm whether I can proceed with pushing the new image to production.

@Kalaiselvi84
Copy link
Contributor Author

Drafted the PR. Sorry, I'm aware that you're currently testing the removal of the Node.js dependency. Please take your time, and kindly let me know when it's appropriate to open this PR and proceed with pushing the image to production.🙂

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 043f19ed-ed50-44f0-88b9-b6b243004da7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3435/head:pr_3435 && git checkout pr_3435
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-9cf6b5f-amd64

@markmandel
Copy link
Member

Drafted the PR. Sorry, I'm aware that you're currently testing the removal of the Node.js dependency. Please take your time, and kindly let me know when it's appropriate to open this PR and proceed with pushing the image to production.🙂

Nope - all good - please go ahead with this PR when ready. No order of operations required here.

Also (mention this on #3430), would love for you to test the removal of the nodejs dependency, but that's far lower priority now things are working again.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready when you are 👍🏻

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 18, 2023
@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review October 18, 2023 01:34
@Kalaiselvi84
Copy link
Contributor Author

Will push the new image to production upon your confirmation..

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 49fac49e-22bc-4252-b5eb-da14830f518a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3435/head:pr_3435 && git checkout pr_3435
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-841dd5f-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 3efe3d3 into googleforgames:main Oct 18, 2023
3 checks passed
@markmandel markmandel deleted the nodejs-simple/Dockerfile branch October 18, 2023 16:20
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants