Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump examples/crd-client #3464

Merged
merged 4 commits into from Oct 28, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 26, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e0349292-63d3-42ac-a8f5-7a2a0b2f773d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

That's a new flake, will keep an eye out.

--- FAIL: TestMultiClusterAllocationFromRemote (13.30s)
    --- FAIL: TestMultiClusterAllocationFromRemote/Handle_allocation_request_remotely (0.10s)
        controller_test.go:451: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:451
            	Error:      	Received unexpected error:
            	            	json: cannot unmarshal string into Go struct field GameServerAllocation.status of type v1.GameServerAllocationStatus
            	Test:       	TestMultiClusterAllocationFromRemote/Handle_allocation_request_remotely

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just - just to confirm before approving - you've testing building the image, and the image get's built?

@Kalaiselvi84
Copy link
Contributor Author

Looks just - just to confirm before approving - you've testing building the image, and the image get's built?

Yes, the build and push processes for the crd-client image have succeeded.🙂

https://gist.github.com/Kalaiselvi84/8e6ff111db46918ac0826151653964f3

https://screenshot.googleplex.com/AHYSmqcsGNMLFmX

@Kalaiselvi84
Copy link
Contributor Author

Production now has the new tag for the crd-client image.

https://screenshot.googleplex.com/5bzQva4NGJuv79p

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) October 27, 2023 17:16
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 27, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d2ece7f2-41c5-4f61-ab4a-0e42fc04857f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3464/head:pr_3464 && git checkout pr_3464
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-69f2c26-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 36daba56-d780-4202-9f68-096da64e9bfd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3464/head:pr_3464 && git checkout pr_3464
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-ed3a960-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec7ba29c-b3bd-45c1-a6c7-3a0b3d1741f0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3464/head:pr_3464 && git checkout pr_3464
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-a625f8c-amd64

@markmandel markmandel merged commit c98001a into googleforgames:main Oct 28, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the update-crd-client branch March 15, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants