Bump examples/allocation-endpoint #3465
Conversation
github-actions
bot
added
the
kind/cleanup
|
Build Succeeded 👏 Build Id: 3c0de084-f5b1-4e39-acdc-3e90af42b7f6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -20,7 +20,7 @@ variable "project_id" { | |||
| variable "ae_proxy_image" { | |||
| type = string | |||
| description = "The docker image of the allocation proxy." | |||
| default = "us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.5" | |||
There was a problem hiding this comment.
The version here should only be bumped until the new image has been pushed to the registry.
There was a problem hiding this comment.
This image has been successfully built and pushed to my project. Do we need to test it locally?🤔
There was a problem hiding this comment.
@gongmax, if you approve this PR, I will update the latest tag in production🙂
There was a problem hiding this comment.
Well, ideally we should only update the version here after the new image has been pushed to agones registry. I.e., the steps should be: 1. bump the version in the makefile. 2. build and push the new image. 3. update the image version where it is used, eg this variable.tf file.
I can approve this this time, but please push the image to agones registry ASAP.
There was a problem hiding this comment.
It's done. https://screenshot.googleplex.com/QJjFMME7qVUxMEw
I was under the impression that I had to build and push after receiving approval. Thank you for clarifying.🙂
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, Kalaiselvi84 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 6b502ade-8b78-4538-9dd9-9a8658d5a0ce The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: