Test Rust Image #3499

Kalaiselvi84 · 2023-11-09T18:45:01Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3482

Special notes for your reviewer:

agones-bot · 2023-11-09T20:02:38Z

Build Failed 😱

Build Id: 14cdd146-bb54-4015-97ed-e0cb32375efb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-11-09T20:06:06Z

@zmerlynn you seen a flake like this before?

gke-autopilot-1.26

	helm upgrade --install --atomic --wait --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.37.0-dev-7e89332,agones.image.registry="us-docker.pkg.dev/agones-images/ci" \
	--set agones.image.controller.pullPolicy="Always",agones.image.controller.pullSecret= \
	--set agones.image.extensions.pullPolicy="Always",agones.image.allocator.pullPolicy="Always" \
	--set agones.image.ping.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.service.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&PodHostname=false&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&CountsAndLists=true&Example=true" \
	--set agones.allocator.service.loadBalancerIP=35.201.215.49 \
	--set agones.metrics.serviceMonitor.enabled=false \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Release "agones" does not exist. Installing it now.
W1109 20:01:09.577199      90 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-controller: adjusted resources to meet requirements for containers [agones-controller] (see http://g.co/gke/autopilot-resources)
W1109 20:01:09.982152      90 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-extensions: adjusted resources to meet requirements for containers [agones-extensions] (see http://g.co/gke/autopilot-resources)
W1109 20:01:10.422882      90 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-ping: defaulted unspecified resources for containers [agones-ping] (see http://g.co/gke/autopilot-defaults)
W1109 20:01:10.874079      90 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-allocator: defaulted unspecified resources for containers [agones-allocator] (see http://g.co/gke/autopilot-defaults)
W1109 20:01:11.689608      90 warnings.go:70] AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies.
W1109 20:01:59.494886      90 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Job agones-system/agones-delete-agones-resources: defaulted unspecified resources for containers [pre-delete-delete-agones-resources] (see http://g.co/gke/autopilot-defaults)
Error: release agones failed, and has been uninstalled due to atomic being set: customresourcedefinitions.apiextensions.k8s.io "gameservers.agones.dev" not found
make: *** [Makefile:426: install] Error 1

markmandel · 2023-11-09T20:06:25Z

May also be worth fixing the conflict, and see it fails the same way again.

agones-bot · 2023-11-09T22:25:23Z

Build Succeeded 👏

Build Id: 12afcec6-0df1-407d-b65a-6982d7649763

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://0872035-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3499/head:pr_3499 && git checkout pr_3499
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-0872035-amd64

markmandel · 2023-11-09T22:29:35Z

test/e2e/examples_test.go

+						{
+							Name:            "rust-simple",
+							Image:           "us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.11",
+							ImagePullPolicy: corev1.PullAlways,


Suggested change

ImagePullPolicy: corev1.PullAlways,

Can we drop the PullAlways please 👍🏻

agones-bot · 2023-11-10T00:19:59Z

Build Succeeded 👏

Build Id: 88b0b7fb-3abe-4f41-8855-97ba30cfc6fe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://734cb09-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3499/head:pr_3499 && git checkout pr_3499
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-734cb09-amd64

google-oss-prow · 2023-11-10T00:27:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Test Rust Image

7e89332

Kalaiselvi84 requested a review from markmandel November 9, 2023 18:45

google-oss-prow bot requested review from aLekSer and roberthbailey November 9, 2023 18:45

google-oss-prow bot added the size/M label Nov 9, 2023

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 9, 2023

fix conflict

2c5eb25

google-oss-prow bot added size/L and removed size/M labels Nov 9, 2023

Merge branch 'main' into rust

0872035

google-oss-prow bot added size/M and removed size/L labels Nov 9, 2023

markmandel reviewed Nov 9, 2023

View reviewed changes

Kalaiselvi84 added 2 commits November 9, 2023 22:39

deleted imagePullPolicy

b7ce599

Merge branch 'rust' of https://github.com/Kalaiselvi84/agones into rust

734cb09

markmandel approved these changes Nov 10, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Nov 10, 2023

google-oss-prow bot added the lgtm label Nov 10, 2023

markmandel merged commit 334a45d into googleforgames:main Nov 10, 2023
3 checks passed

google-oss-prow bot added the approved label Nov 10, 2023

Kalaiselvi84 deleted the rust branch March 15, 2024 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test Rust Image #3499

Test Rust Image #3499

Kalaiselvi84 commented Nov 9, 2023

agones-bot commented Nov 9, 2023

markmandel commented Nov 9, 2023

markmandel commented Nov 9, 2023

agones-bot commented Nov 9, 2023

markmandel Nov 9, 2023

agones-bot commented Nov 10, 2023

google-oss-prow bot commented Nov 10, 2023

Test Rust Image #3499

Test Rust Image #3499

Conversation

Kalaiselvi84 commented Nov 9, 2023

agones-bot commented Nov 9, 2023

markmandel commented Nov 9, 2023

markmandel commented Nov 9, 2023

agones-bot commented Nov 9, 2023

markmandel Nov 9, 2023

Choose a reason for hiding this comment

agones-bot commented Nov 10, 2023

google-oss-prow bot commented Nov 10, 2023