Support appProtocol #3502
Support appProtocol #3502
Conversation
|
Build Succeeded 👏 Build Id: 5b263a4c-80a7-4f3b-b5d2-9e7979adfe35 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Kalaiselvi84
requested review from
markmandel
and removed request for
EricFortin and
aLekSer
| @@ -47,6 +47,9 @@ spec: | |||
| - port: {{ .Values.agones.allocator.service.grpc.port }} | |||
| name: {{ .Values.agones.allocator.service.grpc.portName }} | |||
| targetPort: {{ .Values.agones.allocator.service.grpc.targetPort }} | |||
| {{- if .Values.agones.allocator.service.grpc.appProtocol }} | |||
| appProtocol: {{.Values.agones.allocator.service.grpc.appProtocol}} | |||
There was a problem hiding this comment.
This is the correct approach - but we'll also need a .Values.agones.allocator.service.http.appProtocol in the port section above (line 37 onwards).
There was a problem hiding this comment.
appProtocol is included in the http allocator service
| @@ -233,6 +233,7 @@ The following tables lists the configurable parameters of the Agones chart and t | |||
| | `agones.allocator.replicas` | The number of replicas to run in the deployment | `3` | | |||
| | `agones.allocator.service.name` | Service name for the allocator | `agones-allocator` | | |||
| | `agones.allocator.service.serviceType` | The [Service Type][service] of the HTTP Service | `LoadBalancer` | | |||
| | `agones.allocator.service.grpc.appProtocol` | If the ServiceType is set to "appProtocol", this is useful to connect gRPC with GKE gateway | `""` | | |||
There was a problem hiding this comment.
We'll need to make a copy of the full table and do feature shortcodes like we normally do.
Maybe documentation should read:
The
appProtocolto set on the Service for the gRPC allocation port. If left blank, no value is set.
There was a problem hiding this comment.
The changes are present in the feature shortcodes and the description has been updated as per your suggestion.
There was a problem hiding this comment.
Manual testing for the new changes can be found here - https://gist.github.com/Kalaiselvi84/cebc2fc16a40d3c5faf8750e0e539429
|
Build Succeeded 👏 Build Id: 9e97c92b-d73b-422f-a688-5a57dfe928f7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 80d4352b-3585-456e-8deb-06d4353d036c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
This looks good to me - @hangyoun since you reported the issue, does this look good to you?
|
Thank you, it will be just what I was looking for. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: ee2e871f-c390-40f9-8e7e-13d40821e4d2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3485
Special notes for your reviewer: