Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another List fleet autoscaler e2e test #3521

Merged
merged 1 commit into from Nov 30, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 28, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Approved

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2c876ed9-6078-4121-a8eb-9188e407d4d9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Looks like a legit panic we should solve:

--- FAIL: TestListAutoscalerWithSDKMethods (38.42s)
panic: runtime error: index out of range [2] with length 2 [recovered]
	panic: runtime error: index out of range [2] with length 2

goroutine 1169 [running]:
testing.tRunner.func1.2({0x28bea20, 0xc000043758})
	/usr/local/go/src/testing/testing.go:1526 +0x372
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x650
panic({0x28bea20, 0xc000043758})
	/usr/local/go/src/runtime/panic.go:890 +0x263
agones.dev/agones/test/e2e.TestListAutoscalerWithSDKMethods.func1(0x0?)
	/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:1423 +0xba8
testing.tRunner(0xc0009081a0, 0xc00034e0a0)
	/usr/local/go/src/testing/testing.go:1576 +0x217
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x806
FAIL test/e2e.TestListAutoscalerWithSDKMethods (38.42s)
FAIL test/e2e
=== RUN   TestSuperTuxKart

auto-merge was automatically disabled November 28, 2023 23:44

Head branch was pushed to by a user without write access

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 6342d95 to 051cfd9 Compare November 28, 2023 23:45
@igooch
Copy link
Collaborator Author

igooch commented Nov 28, 2023

Looks like a legit panic we should solve

Yep, made the update to wait until the first autoscale (specifically downsize) is complete before grabbing the list of gameservers.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ae083b24-9318-437b-86d3-e378937d9a21

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from b831ad2 to e985d9d Compare November 29, 2023 20:38
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Nov 29, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 562a134c-70ea-42b0-9671-c4ae5302ecfc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 21727569-1058-468b-92d4-9de2169a4ee3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3521/head:pr_3521 && git checkout pr_3521
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-602c031-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Nov 30, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit fc192db into googleforgames:main Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants