Xonotic Example: Docker 24.0.6 #3538

Kalaiselvi84 · 2023-12-12T18:34:24Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3530

Special notes for your reviewer:

Kalaiselvi84 · 2023-12-12T19:06:00Z

Success log - https://gist.github.com/Kalaiselvi84/77433f8bb46044fb8d220fd09bc32214

Pending: Will push new image to prod once this PR is merged

agones-bot · 2023-12-12T19:44:31Z

Build Failed 😱

Build Id: c93d3fed-640f-4645-bbed-fc0239ae515b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-12-12T21:11:13Z

Build Failed 😱

Build Id: fb18a503-0cd7-410b-aefb-85b4688fe6d0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2023-12-12T21:50:40Z

examples_test.go:221: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:221
VERBOSE:         	Error:      	Received unexpected error:
VERBOSE:         	            	waiting for {xonotic [{default Dynamic <nil> 26000 0 UDP}] {false 5 0 60}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{xonotic us-docker.pkg.dev/agones-images/examples/xonotic-example:1.6 [] []  [] [] [] {map[] map[cpu:{{200 -3} {<nil>} 200m DecimalSI} memory:{{734003200 0} {<nil>} 700Mi BinarySI}] []} [] [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] []}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1702415136/xonotic-bm8jm to be Ready: context deadline exceeded
VERBOSE:         	Test:       	TestXonoticGameServerReady
VERBOSE: --- FAIL: TestXonoticGameServerReady (300.11s)

E2E test failure seems related

gongmax · 2023-12-12T21:52:56Z

so xonotic-example:1.6 is not pushed to our registry yet. You should do that first.

Kalaiselvi84 · 2023-12-12T22:25:05Z

so xonotic-example:1.6 is not pushed to our registry yet. You should do that first.

Thanks for the review and update. The new image has been pushed to the registry. Log - https://gist.github.com/Kalaiselvi84/ecfe5fb1f5f94649f62b9e4eefa66384 https://screenshot.googleplex.com/5fBhTkeVyygpUyq

agones-bot · 2023-12-12T23:27:56Z

Build Succeeded 👏

Build Id: e9f8803d-b29d-44cd-811a-eeb3cf937398

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e770774-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3538/head:pr_3538 && git checkout pr_3538
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e770774-amd64

gongmax · 2023-12-13T00:24:51Z

examples/xonotic/Makefile

@@ -84,13 +84,13 @@ push-windows-image-%:
 	$(MAKE) WINDOWS_DOCKER_PUSH_ARGS=--push build-windows-image-$*

 build-windows-image-%: ensure-windows-buildx
-	docker buildx build --platform windows/amd64 --builder $(BUILDX_WINDOWS_BUILDER) -f $(project_path)Dockerfile.windows \
-	--tag=$(server_tag)-windows_amd64-$* --build-arg WINDOWS_VERSION=$* . $(WINDOWS_DOCKER_PUSH_ARGS)
+		DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build --platform windows/amd64 --builder $(BUILDX_WINDOWS_BUILDER) -f $(project_path)Dockerfile.windows \


Is DOCKER_CLI_EXPERIMENTAL=enabled needed? docker buildx build is not an experimental feature.

nit: why extra indentation is added?

This PR addresses this issue

The build for Xonotic was successful without enabling DOCKER_CLI_EXPERIMENTAL and --use flag, but the build failed without these two in the simple-game-server🤔

There is some weirdness, since Cloud Build server is 20.x and we're using the Docker client 24.x -- so sometimes some things don't work as you expect them to with a full 24.x installation.

Are we good with the updates without including the DOCKER_CLI_EXPERIMENTAL=enabled and --use flag? This is the expected update, correct?

As long as it works, I don't mind 😃

Cool, shall we proceed with merging this PR?🙂

agones-bot · 2023-12-13T04:20:45Z

Build Succeeded 👏

Build Id: 685b2e49-7c72-4304-b36d-e63b84ffb50c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://27b4506-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3538/head:pr_3538 && git checkout pr_3538
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-27b4506-amd64

agones-bot · 2023-12-13T05:40:34Z

Build Succeeded 👏

Build Id: 04cdea5d-de13-42bc-b23f-be06b87a6366

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://cefed78-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3538/head:pr_3538 && git checkout pr_3538
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-cefed78-amd64

agones-bot · 2023-12-14T05:54:27Z

Build Failed 😱

Build Id: 7c4c00a3-2c7e-43ac-b4ae-05bb86b8755c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-12-14T09:47:31Z

Build Succeeded 👏

Build Id: 0a102fb2-6e60-42ea-a21f-5772a14ded57

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b4b9f99-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3538/head:pr_3538 && git checkout pr_3538
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-b4b9f99-amd64

Xonotic Example: Docker 24.0.6

62c6256

Kalaiselvi84 requested a review from markmandel December 12, 2023 18:34

github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Dec 12, 2023

update cloudbuild.yaml

e770774

gongmax reviewed Dec 13, 2023

View reviewed changes

Kalaiselvi84 added 2 commits December 13, 2023 02:54

Remove DOCKER_CLI_EXPERIMENTAL=enabled

3f83ee0

fix indentation

27b4506

remove --use

cefed78

gongmax approved these changes Dec 13, 2023

View reviewed changes

markmandel approved these changes Dec 14, 2023

View reviewed changes

markmandel enabled auto-merge (squash) December 14, 2023 04:35

markmandel and others added 2 commits December 13, 2023 20:35

Merge branch 'main' into xon-docker-24.x

5fe4fb6

Merge branch 'main' into xon-docker-24.x

1f635f8

Merge branch 'main' into xon-docker-24.x

b4b9f99

markmandel merged commit f9b74ef into googleforgames:main Dec 14, 2023
4 checks passed

Kalaiselvi84 deleted the xon-docker-24.x branch March 15, 2024 01:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xonotic Example: Docker 24.0.6 #3538

Xonotic Example: Docker 24.0.6 #3538

Kalaiselvi84 commented Dec 12, 2023 •

edited

Kalaiselvi84 commented Dec 12, 2023

agones-bot commented Dec 12, 2023

agones-bot commented Dec 12, 2023

gongmax commented Dec 12, 2023

gongmax commented Dec 12, 2023

Kalaiselvi84 commented Dec 12, 2023

agones-bot commented Dec 12, 2023

gongmax Dec 13, 2023

Kalaiselvi84 Dec 13, 2023 •

edited

markmandel Dec 13, 2023

Kalaiselvi84 Dec 13, 2023

markmandel Dec 13, 2023

Kalaiselvi84 Dec 13, 2023

agones-bot commented Dec 13, 2023

agones-bot commented Dec 13, 2023

agones-bot commented Dec 14, 2023

agones-bot commented Dec 14, 2023

Xonotic Example: Docker 24.0.6 #3538

Xonotic Example: Docker 24.0.6 #3538

Conversation

Kalaiselvi84 commented Dec 12, 2023 • edited

Kalaiselvi84 commented Dec 12, 2023

agones-bot commented Dec 12, 2023

agones-bot commented Dec 12, 2023

gongmax commented Dec 12, 2023

gongmax commented Dec 12, 2023

Kalaiselvi84 commented Dec 12, 2023

agones-bot commented Dec 12, 2023

gongmax Dec 13, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Dec 13, 2023 • edited

Choose a reason for hiding this comment

markmandel Dec 13, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Dec 13, 2023

Choose a reason for hiding this comment

markmandel Dec 13, 2023

Choose a reason for hiding this comment

Kalaiselvi84 Dec 13, 2023

Choose a reason for hiding this comment

agones-bot commented Dec 13, 2023

agones-bot commented Dec 13, 2023

agones-bot commented Dec 14, 2023

agones-bot commented Dec 14, 2023

Kalaiselvi84 commented Dec 12, 2023 •

edited

Kalaiselvi84 Dec 13, 2023 •

edited