Switch Agones to Go Modules #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 9fc24694-8b0b-4f95-93c9-c710b26bc934 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
reviewed
Mar 17, 2019
|
Build Succeeded 👏 Build Id: 4041434a-ed7f-4d9c-a4b6-e6454d23d462 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Going to take this for a spin and if all works well, then I'll approve (it should, since it passed CI, but just want to get the human feel) One thing - please squash this down to one commit, per contributing guidelines, thanks! Will try and get this done today, GDC forgiving 👍 |
per https://goo.gl/uNhtJ2 Shorten and fix troubleshooting section Remove period in readme toc Realign bullet points OCD about punctuation Add vendoring documentation, update grpc comment
|
Build Succeeded 👏 Build Id: 8a3b7228-74a5-4dfb-9a10-8eaed321aa76 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
kind/cleanup
markmandel
approved these changes
Mar 18, 2019
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 3, 2019
Keep running into [googleforgames#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 3, 2019
Keep running into [googleforgames#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
markmandel
added a commit
that referenced
this pull request
Apr 4, 2019
Keep running into [#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the files in this PR are in vendor
For a detailed explanation see the Design Doc.
This is for issue #625