Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the website theme and add Ubisoft logo #704

Merged
merged 2 commits into from Apr 15, 2019

Conversation

cyriltovena
Copy link
Collaborator

  • Changes website theme to be more in line with Agones.
  • Adds Ubisoft logo.
  • Adds asciinema demo of a fleet.

@cyriltovena cyriltovena added the area/site The website itself - including redirects, styling, search, etc label Apr 13, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4d2a8a2c-1bf8-4b8d-929a-d8045e0be550

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d72ce144-21a9-4c45-95c2-6dd923300d6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 126707d5-c9b8-4483-98c5-8716a3f64665

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/704/head:pr_704 && git checkout pr_704
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-fae47b9

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisnotapril I'm sure will have feedback 😄

The only big feedback I have is, to pull the "What is Agones?" up - rather than fill the entire screen, just have a set size for it. On my larger monitor, it's a LOT of white space (added comment inline as well)

For example - I think gvisor.dev does this quite nicely.

Otherwise - I think this is an awesome improvement 👍

@@ -4,22 +4,22 @@

+++

{{< blocks/cover title="Host, run and scale dedicated game servers on Kubernetes" image_anchor="top" height="full" color="orange" >}}
{{< blocks/cover title="" image_anchor="top" height="full" color="white" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how, but was thinking to remove the td-cover-block--height-full css class from this section in the redered html looks nicer (so it doesn't take up the full page)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it td-cover-block--height-min and it much better !

@thisisnotapril
Copy link
Collaborator

I love it!! This looks awesome @Kuqd. Same comment re: white space that @markmandel had.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 65730cf1-cea6-475b-945f-d58d4efe7b08

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/704/head:pr_704 && git checkout pr_704
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e61ee05

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a9a15261-c882-4610-ae9a-59c8a4e3e4bf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/704/head:pr_704 && git checkout pr_704
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-4a0bfea

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cf5208c0-edd6-48e6-bd65-7eb2d40ab031

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7ff7bd7e-bfae-4485-8ced-14ef3fd1023d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

LGTM too. Cyril, looks like we have some CLA issues (also not sure why this keeps failing to build - I think hugo is being a pain)

Also - this made me realise the app engine cleanup script were cleaning from last->first deployed, not first->last.. which is why previews only lasted ~12 hours 😕

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ad5fb521-9c76-4d38-bae9-18f115baa91f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fe336fbb-5db2-4900-8ef7-b93efbafd41d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/704/head:pr_704 && git checkout pr_704
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-23837db

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 26a999a5-8b9c-4ad8-a859-6915d3e5f4ae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/704/head:pr_704 && git checkout pr_704
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-138dab2

@cyriltovena cyriltovena merged commit 97fdbf6 into googleforgames:master Apr 15, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site The website itself - including redirects, styling, search, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants