Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReserveUntil to GameServer.Status #865

Merged
merged 1 commit into from Jul 10, 2019
Merged

Add ReserveUntil to GameServer.Status #865

merged 1 commit into from Jul 10, 2019

Conversation

markmandel
Copy link
Member

This is to track and display when a Reserved GameServer is reserved until.

Work on #660

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 3, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: af7abe5a-48ba-439b-a64d-8c9d17d86c6b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dc687f23-38be-48d6-987a-f34b2a8cf334

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/865/head:pr_865 && git checkout pr_865
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0eb0d9c

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel
Add ReserveUntil to GameServer.Status
4ec3a2a 
This is to track and display when a Reserved GameServer
is reserved until.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e5414f43-e6ca-43f3-9c9e-8302fa22e78d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/865/head:pr_865 && git checkout pr_865
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-4ec3a2a

@markmandel markmandel merged commit 577d690 into googleforgames:master Jul 10, 2019
@markmandel markmandel deleted the feature/reserve-until branch July 10, 2019 03:02
@markmandel markmandel added this to the 0.12.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markmandel @agones-bot @ilkercelikyilmaz